Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made linkbutton of type button #2073

Merged
merged 4 commits into from Jan 31, 2020
Merged

Made linkbutton of type button #2073

merged 4 commits into from Jan 31, 2020

Conversation

@srinaath
Copy link
Contributor

srinaath commented Jan 31, 2020

Fixes #2031

===

angular/angular#12643

Without the type button inside the form. When an input is in focus the default HTML behavior is to pick the first button and trigger it when Enter key is pressed

Srinaath Ravichandran
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 31, 2020

Coverage Status

Coverage remained the same at 67.983% when pulling 0d9cc37 on srravich/bugfix/2031-entry-key into 8201114 on master.

Srinaath Ravichandran
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Copy link
Contributor

tonyanziano left a comment

Nice!

@tonyanziano

This comment has been minimized.

Copy link
Contributor

tonyanziano commented Jan 31, 2020

This fixes #2031 I assume?

@srinaath

This comment has been minimized.

Copy link
Contributor Author

srinaath commented Jan 31, 2020

@tonyanziano correct. it fixes the opening of "Azure government" page when hitting enter

@srinaath srinaath merged commit 99be493 into master Jan 31, 2020
2 checks passed
2 checks passed
Emulator-CI-PR #103062 succeeded
Details
license/cla All CLA requirements met.
Details
@srinaath srinaath deleted the srravich/bugfix/2031-entry-key branch Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.