Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attachments background and fonts handled when WC will be bumped to 4.8 #2088

Merged
merged 4 commits into from Mar 3, 2020

Conversation

@srinaath
Copy link
Contributor

srinaath commented Feb 28, 2020

Fixes #2071
Handling upload, download attachment styles of webchat from inside the emulator. These changes will be visible only after Webchat is bumped to 4.8.

Screen Shot 2020-02-28 at 3 25 54 PM
Screen Shot 2020-02-28 at 3 26 17 PM
Screen Shot 2020-02-28 at 3 26 31 PM

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Srinaath Ravichandran
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
@srinaath srinaath changed the title Attachments background and fonts handled when WC will be bumped to Attachments background and fonts handled when WC will be bumped to 4.8 Feb 28, 2020
Srinaath Ravichandran
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Copy link
Contributor

tonyanziano left a comment

1 minor comment, other than that it looks good to me 👍

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 29, 2020

Coverage Status

Coverage decreased (-0.01%) to 68.151% when pulling 2ac633e on srravich/feature/2071-download-upload-styles into 6b8b532 on master.

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
@srinaath srinaath merged commit e92279e into master Mar 3, 2020
2 checks passed
2 checks passed
Emulator-CI-PR #109797 succeeded
Details
license/cla All CLA requirements met.
Details
@srinaath srinaath deleted the srravich/feature/2071-download-upload-styles branch Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.