Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attachments background and fonts handled when WC will be bumped to 4.8 #2088

Merged
merged 4 commits into from Mar 3, 2020

Conversation

srinaath
Copy link
Contributor

Fixes #2071
Handling upload, download attachment styles of webchat from inside the emulator. These changes will be visible only after Webchat is bumped to 4.8.

Screen Shot 2020-02-28 at 3 25 54 PM
Screen Shot 2020-02-28 at 3 26 17 PM
Screen Shot 2020-02-28 at 3 26 31 PM

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
@srinaath srinaath changed the title Attachments background and fonts handled when WC will be bumped to Attachments background and fonts handled when WC will be bumped to 4.8 Feb 28, 2020
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor comment, other than that it looks good to me 👍

@coveralls
Copy link

coveralls commented Feb 29, 2020

Coverage Status

Coverage decreased (-0.01%) to 68.151% when pulling 2ac633e on srravich/feature/2071-download-upload-styles into 6b8b532 on master.

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
@srinaath srinaath merged commit e92279e into master Mar 3, 2020
@srinaath srinaath deleted the srravich/feature/2071-download-upload-styles branch March 7, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove styling for download icon
3 participants