Moved next() in handler to fix early HTTP response termination. #2320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyanziano
requested review from
a-b-r-o-w-n,
compulim,
cwhitten,
srinaath and
tdurnford
as code owners
cwhitten
previously approved these changes
Nov 11, 2021
a-b-r-o-w-n
previously approved these changes
Nov 11, 2021
a-b-r-o-w-n
previously approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a misplaced
next()call in thereplyToActivity.tshandler that is responsible for posting messages from the bot back to Web Chat. Thisnext()call was terminating the response earlier than the call tores.send(HttpStatus.OK, { id: activity.id });on line 62 which was causing the newer version of NodeJS to throw when it was not before on the older version.