-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge production Web Chat #623
Conversation
@@ -148,7 +147,7 @@ export function newDocument(documentId: string, mode: ChatMode, additionalData?: | |||
mode, | |||
documentId, | |||
conversationId: null, | |||
webChatStore: createWebChatStore(), | |||
// webChatStore: createWebChatStore(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this no longer required? If so can we just delete the line?
@compulim so good to see so much custom code get deleted! Awesome PR 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Now, we can use production Web Chat without modifications in Emulator:
Caveats:
After merging this PR, we will show send box and interactivity even we load transcript, this is because the PR for hiding send box is pending approval on Web Chat. Once it's in Web Chat, we can bump version and get that fixed without code change. Will track in another bug.
Some design considerations: