-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The action button size is not align with adaptive card designer #1964
Comments
We may want to transfer this over to Web Chat before addressing in Emulator. (Used the json provided by @DingmaomaoBJTU and see the same behavior in Web Chat) |
Sounds like Web Chat should send our new hostconfig over to Adaptive Cards. Could we get this issue transferred to Web Chat? |
I sent a message to a rep of the Adaptive Cards team asking that they update their site with our new hostconfig. I haven't heard anything back yet, but I will continue to check-in and report back here. :) |
Thank you so much!~ |
I got a response from the Adaptive Card team :) Web Chat is free to do a PR to their repo with the updated host config. Since Adaptive Cards' v.next has a lot of new changes, updating the file will not be trivial. We're keeping this for the 4.5 milestone, but I will work on this at a later date when I can delegate more time to it. I would still super love to have another Adaptive Cards on Web Chat design pass. @DesignPolice, what do you think? |
Is this fixed ? Riased a similer issue in SO .. |
I have made the PR for this fix on the Adaptive Cards repo: microsoft/AdaptiveCards#3040 Since AdaptiveCards is owned by a different team, we're not privy to their PR review schedule, so I'm not sure how quickly this will be merged in, or when their next release is planned for. I will keep this issue open for tracking when that PR is merged into Adaptive Cards, after which I will close this as resolved. At the moment, there is no action item for the Web Chat team. |
Awesome! Adaptive Cards just merged my PR, so we can expect the designer to be updated with Web Chat's designs by their next release. Closing this issue as resolved. Thanks for your patience everyone. |
Great. So when can we expect the same ? |
You would have to ask Adaptive Cards when their next release is. Unfortunately I don't have that information. |
Hi, is there a sample code on how to use these changes? |
Version
v4.4.0
Describe the bug
The action button style is not align with adaptive card designer.
To Reproduce
What I see in the designer:
![image](https://user-images.githubusercontent.com/16643193/57190182-4658d280-6f4a-11e9-8869-393692dc5da5.png)
What I see in emulator:
![image](https://user-images.githubusercontent.com/16643193/57190185-507ad100-6f4a-11e9-951b-61171cf49c55.png)
Here is the adaptive card I use:
Expected behavior
Keep emulator card display the same as adaptive card designer.
[bug]
The text was updated successfully, but these errors were encountered: