Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebChat version to UserAgent #1985

Closed
EricDahlvang opened this issue May 14, 2019 · 2 comments · Fixed by #2101
Closed

Add WebChat version to UserAgent #1985

EricDahlvang opened this issue May 14, 2019 · 2 comments · Fixed by #2101
Assignees
Labels
front-burner p1 Painful if we don't fix, won't block releasing support Internal request for assistance from the Support Team

Comments

@EricDahlvang
Copy link
Member

Feature Request

It would be useful for diagnostics and analytics to know the WebChat version that is sending messages.

[Enhancement]

@compulim
Copy link
Contributor

Great idea.

The window.WebChat.createDirectLine function in the bundle should put/append Web Chat version as bot agent. There is an option called botAgent.

@EricDahlvang few questions:

  • What do you think about the format of the bot agent? E.g. WebChat/4.4.1?
  • How about the user want to append their own? Should we always append WebChat/4.4.1 to what the user provided?
  • Web Chat has different loading mechanisms, should we list them out?
    • Bundle: full bundle (include Adaptive Cards), minimal bundle (no Markdown)
    • Channel: CDN, NPM, embed (currently, it is difficult to get this)

@corinagum it's modifying the bundle, not difficult because it is more-or-less similar to how createStyleSet work. And you know we have 3 versions in meta tag, use the one from bundle.

@EricDahlvang
Copy link
Member Author

The adaptive cards version can be determined based on the WebChat build version. But, as much information as we can provide regarding customer enabled features and loading mechanisms seems good.

@corinagum corinagum added 4.5 p1 Painful if we don't fix, won't block releasing front-burner and removed Triage-E labels May 23, 2019
@tdurnford tdurnford added the support Internal request for assistance from the Support Team label May 24, 2019
@corinagum corinagum moved this from P1 to To do in R8 Prioritization Jun 10, 2019
@tdurnford tdurnford moved this from To do to In progress in R8 Prioritization Jun 10, 2019
@compulim compulim moved this from In progress to To do in R8 Prioritization Jun 13, 2019
@compulim compulim moved this from To do to In progress in R8 Prioritization Jun 13, 2019
@corinagum corinagum moved this from In progress to Done in R8 Prioritization Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-burner p1 Painful if we don't fix, won't block releasing support Internal request for assistance from the Support Team
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants