Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the Web Chat Version and Bundle to User Agent #2101

Merged
merged 11 commits into from
Jul 1, 2019

Conversation

tdurnford
Copy link
Contributor

Fixes #1985

Changelog Entry

Per issue #1985, added the Web Chat version to DirectLine's botAgent option, by @tdurnford, in PR #2101

Specific Changes

Modified the createDirectLine functions in index-*.ts files to set the botAgent with the version and bunble of Web Chat being used.


  • Testing Added

@msftclas
Copy link

msftclas commented Jun 20, 2019

CLA assistant check
All CLA requirements met.

@tdurnford tdurnford changed the title 1985 Added the Web Chat Version and Bundle to User Agent Jun 20, 2019
@tdurnford tdurnford marked this pull request as ready for review June 20, 2019 21:24
packages/bundle/src/createDirectLine.js Outdated Show resolved Hide resolved
packages/bundle/src/index-minimal.ts Outdated Show resolved Hide resolved
packages/bundle/src/index.ts Show resolved Hide resolved
packages/bundle/src/index.ts Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
packages/component/src/Localization/tr-TR.js Outdated Show resolved Hide resolved
packages/bundle/src/index-es5.ts Outdated Show resolved Hide resolved
packages/bundle/src/FullReactWebChat.js Outdated Show resolved Hide resolved
packages/bundle/src/index-es5.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you write tests for all 3 bundles?

packages/bundle/src/index-es5.ts Outdated Show resolved Hide resolved
packages/bundle/src/index-minimal.ts Outdated Show resolved Hide resolved
packages/bundle/src/index.ts Outdated Show resolved Hide resolved
tdurnford and others added 3 commits June 25, 2019 10:48
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
Copy link
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking, looks very good.

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
packages/bundle/src/__tests__/createDirectLine.spec.js Outdated Show resolved Hide resolved
packages/bundle/src/__tests__/createDirectLine.spec.js Outdated Show resolved Hide resolved
packages/bundle/src/__tests__/createDirectLine.spec.js Outdated Show resolved Hide resolved
@corinagum corinagum merged commit 3d55e1e into microsoft:master Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add WebChat version to UserAgent
4 participants