Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputHint not respected by WebChat in speech scenarios #2022

Closed
darrenj opened this issue May 22, 2019 · 1 comment · Fixed by #2149 or #2166
Closed

InputHint not respected by WebChat in speech scenarios #2022

darrenj opened this issue May 22, 2019 · 1 comment · Fixed by #2149 or #2166
Assignees
Labels
area-speech bug Indicates an unexpected problem or an unintended behavior. front-burner p1 Painful if we don't fix, won't block releasing

Comments

@darrenj
Copy link

darrenj commented May 22, 2019

InputHint not respected by WebChat in speech scenarios

Screenshots

image

image

Version

CDN: latest/webchat.js

Describe the bug

The InputHint on a return activity indicates whether the microphone should be opened to take additional input. ExpectingInput should result in the microphone being opened but it's seemingly ignored.

To Reproduce

  • Open webchat with Bot
  • Ask a question using speech that will trigger a response with InputHint set.

Expected behavior

  • Microphone to be opened automatically when ExpectingInput set on InputHint.

[Bug]

@darrenj darrenj added bug Indicates an unexpected problem or an unintended behavior. Pending labels May 22, 2019
@compulim compulim self-assigned this May 22, 2019
@corinagum corinagum added 4.5 and removed Triage-E labels May 23, 2019
@corinagum corinagum added the p1 Painful if we don't fix, won't block releasing label Jun 5, 2019
@compulim
Copy link
Contributor

@corinagum could you look at this one?

There are 3 options for input hints: ExpectingInput, AcceptingInput (default), IgnoringInput.

The spec can be found at, https://docs.microsoft.com/en-us/azure/bot-service/dotnet/bot-builder-dotnet-add-input-hints?view=azure-bot-service-3.0. The "Default values for input hint" section is complicated and Web Chat currently do not expect SDK automatically set the InputHint correctly. For example, what if the 2nd last activity has ExpectingInput while the last one is IgnoringInput? I think we should IgnoringInput.

Few things to check:

  • I don't think we have logic for ExpectingInput, please add.
  • We have logic for IgnoringInput, can you check if it work properly?
  • Please check if there are activities mixed with ExpectingInput and IgnoringInput, we should honor the last one in chronologically order.

I looked at v3, ExpectingInput will turn on microphone (although it may fail due to browser block).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-speech bug Indicates an unexpected problem or an unintended behavior. front-burner p1 Painful if we don't fix, won't block releasing
Projects
None yet
3 participants