Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking on suggested actions "openurl" button won't close the suggested actions bar #2160

Closed
compulim opened this issue Jul 9, 2019 · 0 comments · Fixed by #2190
Closed

Clicking on suggested actions "openurl" button won't close the suggested actions bar #2160

compulim opened this issue Jul 9, 2019 · 0 comments · Fixed by #2190
Assignees
@tdurnford
Labels
bug Indicates an unexpected problem or an unintended behavior. front-burner p1 Painful if we don't fix, won't block releasing
Projects
R8 Prioritization

Comments

@compulim
Copy link
Contributor

compulim commented Jul 9, 2019

Screenshots

Connect to MockBot, then type card-actions.

image

The suggested actions will show with a single item named "openUrl". Clicking on it will open a new window, but it won't hide the suggested actions bar. It should hide.

Version

Tested on 4.2.0 and 4.4.2.

Describe the bug

Suggested actions won't hide by clicking on an action of type "openUrl".

To Reproduce

Steps to reproduce the behavior:

  1. Connect to MockBot
  2. Type card-actions
  3. Click "openUrl" in the suggested actions bar
  4. A new window will pop up, go back to Web Chat window
  5. Expect: suggested action bar should goes away

Expected behavior

Suggested action bar should goes away after clicking on it.

Additional context

[Bug]
@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. Pending labels Jul 9, 2019
@corinagum corinagum added Approved p1 Painful if we don't fix, won't block releasing front-burner and removed Pending labels Jul 9, 2019
@tdurnford tdurnford self-assigned this Jul 10, 2019
@corinagum corinagum added this to To do in R8 Prioritization Jul 10, 2019
@tdurnford tdurnford moved this from To do to In progress in R8 Prioritization Jul 11, 2019
@tdurnford tdurnford mentioned this issue Jul 15, 2019
Merged
1 task
@corinagum corinagum moved this from In progress to Done in R8 Prioritization Jul 17, 2019
@compulim compulim mentioned this issue Oct 25, 2019
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tdurnford tdurnford

Labels
bug Indicates an unexpected problem or an unintended behavior. front-burner p1 Painful if we don't fix, won't block releasing
Projects
No open projects
R8 Prioritization
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clear suggested-actions on button click tdurnford/BotFramework-WebChat
3 participants
@compulim @corinagum @tdurnford