Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear suggested-actions on button click #2190

Merged
merged 8 commits into from
Jul 17, 2019
Merged

Clear suggested-actions on button click #2190

merged 8 commits into from
Jul 17, 2019

Conversation

tdurnford
Copy link
Contributor

@tdurnford tdurnford commented Jul 15, 2019 •
edited
Loading

Fixes #2160

Changelog Entry

Fix #2160. Clear suggested-actions after button click, by @tdurnford in PR #2190

Specific Changes

Called the setSuggestedActions function in the suggested action's onClick method to clear the suggested actions bar.

  • Testing Added

@coveralls
Copy link

coveralls commented Jul 15, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.4%) to 63.388% when pulling a64cf4d on tdurnford:2160 into 3bc1b65 on microsoft:master.

compulim
compulim reviewed Jul 15, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
__tests__/suggestedActions.js Outdated Show resolved Hide resolved
__tests__/suggestedActions.js Outdated Show resolved Hide resolved
__tests__/suggestedActions.js Outdated Show resolved Hide resolved
__tests__/suggestedActions.js Outdated Show resolved Hide resolved
packages/core/src/index.js Outdated Show resolved Hide resolved
corinagum
corinagum reviewed Jul 16, 2019
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait for @compulim's input since he had comments previously.

@tdurnford tdurnford requested a review from compulim July 16, 2019 16:52
compulim
compulim approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing. 😉

packages/core/src/actions/clearSuggestedActions.js Outdated Show resolved Hide resolved
@corinagum
Copy link
Contributor

corinagum commented Jul 16, 2019 •
edited
Loading

rebuilding due to timeout (sorry I hit close on accident :( :( :( )

@corinagum corinagum closed this Jul 16, 2019
@corinagum corinagum reopened this Jul 16, 2019
@corinagum corinagum merged commit 84d194b into microsoft:master Jul 17, 2019
@compulim compulim mentioned this pull request Oct 25, 2019
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum left review comments

@compulim compulim compulim approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clicking on suggested actions "openurl" button won't close the suggested actions bar
4 participants
@tdurnford @coveralls @corinagum @compulim