Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ponyfilling window.open #368

Closed
billba opened this issue Mar 10, 2017 · 3 comments · Fixed by #1704
Closed

Allow ponyfilling window.open #368

billba opened this issue Mar 10, 2017 · 3 comments · Fixed by #1704
Assignees
@compulim
Labels
front-burner p0 Must Fix. Release-blocker size-m 1-3 days
Projects
(Deprecated) Ignite: Customizability 4.3 Prioritization
Milestone
v4.3

Comments

@billba
Copy link
Member

billba commented Mar 10, 2017 •
edited
Loading

Right now we call window.open(url) for card actions. The default in most browsers is to open the url in a new tab, but some might like to open it in a new window, etc.

My proposal is to add urlTarget?:string and urlTitle?:string to ChatProps. If supplied we'd pass them as the second and third parameter to window.open.
@danmarshall
Copy link
Contributor

is it Title or "specs"
https://www.w3schools.com/jsref/met_win_open.asp

@billba
Copy link
Member Author

billba commented Mar 10, 2017

I was going by the TypeScript, but even then I got it wrong:

Window.open(url?: string, target?: string, features?: string, replace?: boolean): Window

compulim pushed a commit to compulim/BotFramework-WebChat that referenced this issue Jul 14, 2018
@mgbennet @eanders-ms
Fix for log panel being minimized by default. (microsoft#368)
37bb7d8
@compulim compulim added this to the v4.2 milestone Oct 24, 2018
@corinagum corinagum added 4.3 p1 Painful if we don't fix, won't block releasing and removed 4.2 labels Nov 27, 2018
@compulim compulim changed the title Specify URL target Allow ponyfilling window.open Nov 27, 2018
@corinagum corinagum added p0 Must Fix. Release-blocker front-burner and removed p1 Painful if we don't fix, won't block releasing labels Nov 28, 2018
@compulim compulim modified the milestones: v4.2, v4.3 Nov 28, 2018
@corinagum corinagum mentioned this issue Nov 29, 2018
Closed
@compulim compulim added the size-m 1-3 days label Dec 8, 2018
@corinagum
Copy link
Contributor

Related to #1504

@corinagum corinagum mentioned this issue Dec 18, 2018
Closed
@compulim compulim modified the milestone: v4.3 Dec 18, 2018
@corinagum corinagum moved this from P0 to In-Flight in 4.3 Prioritization Jan 17, 2019
justinwilaby added a commit that referenced this issue Jan 17, 2019
@justinwilaby
#368 - initial props structure
dab0ecd
@justinwilaby justinwilaby mentioned this issue Jan 23, 2019
Closed
@corinagum corinagum moved this from In-Flight to Review in 4.3 Prioritization Jan 23, 2019
@compulim compulim mentioned this issue Feb 6, 2019
Merged
@compulim compulim mentioned this issue Feb 6, 2019
Closed
@justinwilaby justinwilaby assigned compulim and unassigned justinwilaby Feb 8, 2019
4.3 Prioritization automation moved this from Review to Done Feb 12, 2019
@justinwilaby justinwilaby mentioned this issue Jun 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@compulim compulim

Labels
front-burner p0 Must Fix. Release-blocker size-m 1-3 days
Projects
No open projects
(Deprecated) Ignite: Customizability
  
Triage
4.3 Prioritization
  
Done
Milestone
v4.3
Development

Successfully merging a pull request may close this issue.

Ponyfilling window.open compulim/BotFramework-WebChat
6 participants
@sgellock @compulim @justinwilaby @billba @danmarshall @corinagum