Support tamper-proof user ID from MockBot #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Self-approving non-production code change. |
compulim
added a commit
that referenced
this pull request
Oct 31, 2018
* Remove typing after 5s * Cleanup * Update action name * Improve perf * Update Adaptive Card styles * Update README.md * Use WebSocket for MockBot * Dedupe by skipping existing activity ID * Take clockskew into account * More clockskew fix * Fix Edge problem * Send typing with debouncer * Auto submit on speech input * Setup Web Speech polyfill * Add Web Speech polyfill * Add Bing Speech to playground * Do not send empty speech transcript * Use custom class instead of extra * Get speech token on-demand * Speak out text after speak input * Move speaking logic to backend * Move speech input to backend * Add TODO * Handsfree mode * Move microphone button out of text box * Disable speech recognition if not supported * Cosmetics * Add TODO * Move send box to backend * Add submitSendBox action * Move sendMessage to Redux action * Move sendTyping to Redux * Cleanup start/stop speak logic * Update to use createConnectAction * Rename interface to settings * Support sign-in flow * Hide empty bubbles * Add TODO * Fix retry send and bump DirectLineJS * Fix typing not showing up * Cleanup * Move activities and suggestedActions to read from Redux * Add browser bundle story * Add Webpack * Add Cognitive Services to bundle * Add Webpack visualizer * Add bundle variations * Prepare should run build first * Use prepublishOnly * Support reference grammar ID * Mark ported code * Move sendFiles to Redux * Cleanup * Cleanup * Add TODO * Cleanup * Cleanup * Move to middleware-based renderer * Add comments * Add unknown card * Refactor debug container * Add TODO * Add activity render middleware * Add language to timestamp and cleanup * Cleanup * Add basic language support * Add logic to languages * Add more strings * Add Japanese strings * Localize sending message * Add more localized strings * Add TODO * Toggle-able sendTyping * Cleanup * Collapse timestamp * Configurable collapse timestamp * Add script * Configurable avatar initials * Move to style set * Extract paddingRegular * Add localization * Cleanup * Cleanup * Cleanup * Add styled bubble from user * Cosmetics * Cosmetics * Add POC.md * Rank the list * Add links to GitHub issues * Sample: using from CDN * Cleanup v1 * Update SAMPLES.md * Code review * Code review * Rename to lowercase * Add SendState constants * Fix runtime break * Cleanup * Move dev mode renderer to playground * Differentiate between error and deprecations * Separate retry send into another component * Rename SendState to ActivityClientState * Add faulty Direct Line for testing * Mark TODO with priorities * Update priorities * Update priorities * Rename packages * Rename String to Localize * Add logo asset * Fix build break * Update TODO * Add serve.json * Flush out first sample * More samples * Update POC.md * Add React integration sample * Update README.md * Update README.md * Rename * Fix bundling * Rename * Update README.md * Add GItHub repository sample * Cleanup * Better middleware architecture * Fix build break * Cleanup * Add comment * Add activity decorator band * Add activity decorator for buttons * Use postback * Accessibility contrast * Postback as string * Use dispatcher for post back * Update POC.md * Add connectWithContext * Composer use storeKey * Add TODO * Cleanup * Move Adaptive Cards dependency to attachment * Move sanitize to bundle-full * Update SAMPLES.md * Move backend-cli to samples * Renaming packages * Fix after merge * Fix merge * Cleanup * Fix build break * Override instead of replace default style options * Update LICENSE * Add Redux middleware sample * Incorporate code review comments * Update SAMPLES.md * More samples * Add styleOptions sample * Add TODO * Add link to article * Add presentation mode style options * Disable suggested actions thru props * Disable tappable image * Disable tappable text * Cleanup * Cleanup * Fix serialization * Update README.md * Add screenshot * Center screenshot * Update README.md Initial pass * Update docs * Update samples * Update image width * Update images * Update code snippets * Add secret param * Update docs * Update docs * Update docs * Update docs * Travis on CDN * Uncomment tag section * Install lerna before sync version * Update package-lock.json * Disable git on version * Use --no-git-tag-version instead * Use lerna exec npm version * Update package version * Update package name * Use temp branch * Ignore changes * Force publish * Add quiet * Add NPM * Update CDN dest * Fix path * Fix path * Fix publish script * Skip cleanup * Add .npmrc * Use npm publish * Use preview tag * Public access publish * Update to preview branch * Update dependencies (#1168) * Update URLs * Deploy Markdown files (#1169) * Update to absolute URL Relative URL doesn't work well in NPM * Cleanup samples (#1170) * Cleanup samples * Update link * Deploy GitHub pages (#1172) * Add hosted samples page * Move build_pages to deploy * Fix copy script * Update dest * Correct homepage path * Add source links * Support tamper-proof user ID (#1184) * Sample: IE11 compatibility (#1183) * Update polyfill * Remove bluebird * Update README.md for ES5 sample * Clean up comment * Add parseURL * Add isFinite for file upload * Video layout for IE11 * Add gitignore for serve * Add Japanese 'X minutes ago' localization (#1193) * add x minutes ago localization for Japanese * Add localization tests for Japanese * Format/indentation * Format/indentation * Sample: Speech thru Cognitive Services and browser support (#1190) * Move dictation to a headless component * Cleanup * Cleanup * Update serve.json * Update README.md * Cleanup * Remove enableSpeech * Add browser speech sample * Cleanup bundle * Add warnings for non-supported browser * Fix broken build * Update package-lock.json * Add TODO * Break dictation interims to its own component * Update TODOs * Cleanup * Don't parallel build * Incorporate PR changes * Add quick speak test * Update package-lock.json * Sample: group timestamp (#1189) * Group timestamp sample * Update README.md * Add backchannel sample (#1191) * Fix playground not building on Docker (#1197) * Add React sample (#1200) * Add language (#1206) * Fix URL parsing in modern browsers (#1213) * Numerous fixes for playground (#1214) * Carousel should show on dev mode speak activity * Default language should read from window.navigator.language * Lerna version should use exact version (#1219) * Honor locale on speech recognition and synthesis (#1220) * Option to hide timestamp * Prefer user ID from token * Remove username * Minor update to pl-Pl localization (#1225) * Add alt text * Add nb-NO (#1203) * Simplify Provider/connect and hide Redux (#1222) * Simplify Provider/connect and hide Redux * Use latest Web Chat in samples * Flatten Redux store * Rename upsertActivity to incomingActivity * Add TODO * Rename action family * Rename speech input to dictate * Update package-lock.json * Move serve.json to root * Fixing samples * Revisit all breakaway components to make sure they are easy to recompose (#1226) * Simplify Provider/connect and hide Redux * Flatten Redux store * Rename upsertActivity to incomingActivity * Rename action family * Simplify show/hide activities/timestamps * Expose UI and fix propTypes * Expose more UI components * Exposing more UIs * Add breakaway speech button sample * Making breakaway components more easy to reuse * Move to connectWithContext and remove withStyleSet * Fix build break * Move all to connectWithContext * Move Basic* to top-level and un-expose Context * Fix styleSet null * Rename activity2 to activity * Cleanup * Cleanup * Move default store to Composer * Add custom UI * Remove speech only button demo from playground * Cleanup * Update README.md * Update README.md * Update package-lock.json * Fix build break * Remove package-lock.json from samples * Add build script for breakaway speech button * Rename connectWithContext to connectToWebChat * Clean up * Bundling package-lock.json for npm ci * Corinagum/preview samples (#1235) * Update full-bundle README.md * Add more details and code snippets to full-bundle sample * minor edits to full-bundle readme * Clean up full-bundle readme * some minor edits + integrate with react README * Add README file to speech cognitive services sample * insignificant updates to previous samples * fix reference to wrong file * add speech browser sample * Add minimal bundle sample readme * README PR fixes & update CHANGELOG * reduce changelog line's character count * Adding empty lines for clarity * Update README.md - Adding empty lines after header - Removing `## Description` because it convey no meanings - Consistent upper/lowercase for header title (First word uppercase, other lowercase) * Styling update - Also make sure header level are continuous and not discrete (# -> ## instead of # -> ###) * Styling * Styling * Styling * Stying * Accessibility pass using Keros (#1233) * Simplify Provider/connect and hide Redux * Flatten Redux store * Rename upsertActivity to incomingActivity * Rename action family * Expose UI and fix propTypes * Remove package-lock.json from samples * Add title attribute * Add alt/title * Use role="img" * Bundling package-lock.json for npm ci * Make cropped image accessible * Make carousel flipper accessible * Revert botchat.js URL change * Allow img alt tag in sanitizer * Clean up * Rename connectWithContext to connectToWebChat * Use unified selector * Render unknown file attachment * Style for carousel * Default to null * Remove padding for filler * Add landmark role * Fix scroll to bottom * Remove external * Bump to react-scroll-to-bottom@1.2.0 * Bump react-film to 1.1.0 * Bump to react-say@1.1.0 * Flipper aria-label * Button title text * Add "Starting..." * Remove redundant narrative * Focus indicator for Firefox * Fix uploading attachment not showing up * Hide scrollbar in Firefox * Fix broken upload * Accessibility fix * Revert targetting debug build * aria-label for input type="file" * Rename UploadAttachmentButton to UploadButton * Focus indicator high contrast mode * Add TODO * Cover instead of contains * Update package-lock.json * Fix build break (#1255) * Update README.md * Catch slow Direct Line response (#1254) * Embed version via bundle (#1256) * Embed version via bundle * Add variant * Sort tag order * Update tag name * Rename botchat-core to botchat-minimal * Fix samples (#1271) * Fix homepage for gh-pages * Move gh-pages * Move gh-pages * Add breakaway speech button * Use lerna for samples written in React (#1272) * Samples use lerna for linking * Change page title * Include package-lock.json * Last mile on GA (#1260) * Add LOCALIZATION.md * Clean up * Fix upload button fail because overriding props * Fix send button not working on click * Guess MIME type for send files to preview photos * Customizable send timeout and default to 20s * Update package-lock.json * Fix audio card null ref on styleSet * Reset the branch * Update package-lock.json * Change preview branch to master branch
ctaleck
pushed a commit
to ctaleck/BotFramework-WebChat
that referenced
this pull request
Nov 1, 2018
* Remove typing after 5s * Cleanup * Update action name * Improve perf * Update Adaptive Card styles * Update README.md * Use WebSocket for MockBot * Dedupe by skipping existing activity ID * Take clockskew into account * More clockskew fix * Fix Edge problem * Send typing with debouncer * Auto submit on speech input * Setup Web Speech polyfill * Add Web Speech polyfill * Add Bing Speech to playground * Do not send empty speech transcript * Use custom class instead of extra * Get speech token on-demand * Speak out text after speak input * Move speaking logic to backend * Move speech input to backend * Add TODO * Handsfree mode * Move microphone button out of text box * Disable speech recognition if not supported * Cosmetics * Add TODO * Move send box to backend * Add submitSendBox action * Move sendMessage to Redux action * Move sendTyping to Redux * Cleanup start/stop speak logic * Update to use createConnectAction * Rename interface to settings * Support sign-in flow * Hide empty bubbles * Add TODO * Fix retry send and bump DirectLineJS * Fix typing not showing up * Cleanup * Move activities and suggestedActions to read from Redux * Add browser bundle story * Add Webpack * Add Cognitive Services to bundle * Add Webpack visualizer * Add bundle variations * Prepare should run build first * Use prepublishOnly * Support reference grammar ID * Mark ported code * Move sendFiles to Redux * Cleanup * Cleanup * Add TODO * Cleanup * Cleanup * Move to middleware-based renderer * Add comments * Add unknown card * Refactor debug container * Add TODO * Add activity render middleware * Add language to timestamp and cleanup * Cleanup * Add basic language support * Add logic to languages * Add more strings * Add Japanese strings * Localize sending message * Add more localized strings * Add TODO * Toggle-able sendTyping * Cleanup * Collapse timestamp * Configurable collapse timestamp * Add script * Configurable avatar initials * Move to style set * Extract paddingRegular * Add localization * Cleanup * Cleanup * Cleanup * Add styled bubble from user * Cosmetics * Cosmetics * Add POC.md * Rank the list * Add links to GitHub issues * Sample: using from CDN * Cleanup v1 * Update SAMPLES.md * Code review * Code review * Rename to lowercase * Add SendState constants * Fix runtime break * Cleanup * Move dev mode renderer to playground * Differentiate between error and deprecations * Separate retry send into another component * Rename SendState to ActivityClientState * Add faulty Direct Line for testing * Mark TODO with priorities * Update priorities * Update priorities * Rename packages * Rename String to Localize * Add logo asset * Fix build break * Update TODO * Add serve.json * Flush out first sample * More samples * Update POC.md * Add React integration sample * Update README.md * Update README.md * Rename * Fix bundling * Rename * Update README.md * Add GItHub repository sample * Cleanup * Better middleware architecture * Fix build break * Cleanup * Add comment * Add activity decorator band * Add activity decorator for buttons * Use postback * Accessibility contrast * Postback as string * Use dispatcher for post back * Update POC.md * Add connectWithContext * Composer use storeKey * Add TODO * Cleanup * Move Adaptive Cards dependency to attachment * Move sanitize to bundle-full * Update SAMPLES.md * Move backend-cli to samples * Renaming packages * Fix after merge * Fix merge * Cleanup * Fix build break * Override instead of replace default style options * Update LICENSE * Add Redux middleware sample * Incorporate code review comments * Update SAMPLES.md * More samples * Add styleOptions sample * Add TODO * Add link to article * Add presentation mode style options * Disable suggested actions thru props * Disable tappable image * Disable tappable text * Cleanup * Cleanup * Fix serialization * Update README.md * Add screenshot * Center screenshot * Update README.md Initial pass * Update docs * Update samples * Update image width * Update images * Update code snippets * Add secret param * Update docs * Update docs * Update docs * Update docs * Travis on CDN * Uncomment tag section * Install lerna before sync version * Update package-lock.json * Disable git on version * Use --no-git-tag-version instead * Use lerna exec npm version * Update package version * Update package name * Use temp branch * Ignore changes * Force publish * Add quiet * Add NPM * Update CDN dest * Fix path * Fix path * Fix publish script * Skip cleanup * Add .npmrc * Use npm publish * Use preview tag * Public access publish * Update to preview branch * Update dependencies (microsoft#1168) * Update URLs * Deploy Markdown files (microsoft#1169) * Update to absolute URL Relative URL doesn't work well in NPM * Cleanup samples (microsoft#1170) * Cleanup samples * Update link * Deploy GitHub pages (microsoft#1172) * Add hosted samples page * Move build_pages to deploy * Fix copy script * Update dest * Correct homepage path * Add source links * Support tamper-proof user ID (microsoft#1184) * Sample: IE11 compatibility (microsoft#1183) * Update polyfill * Remove bluebird * Update README.md for ES5 sample * Clean up comment * Add parseURL * Add isFinite for file upload * Video layout for IE11 * Add gitignore for serve * Add Japanese 'X minutes ago' localization (microsoft#1193) * add x minutes ago localization for Japanese * Add localization tests for Japanese * Format/indentation * Format/indentation * Sample: Speech thru Cognitive Services and browser support (microsoft#1190) * Move dictation to a headless component * Cleanup * Cleanup * Update serve.json * Update README.md * Cleanup * Remove enableSpeech * Add browser speech sample * Cleanup bundle * Add warnings for non-supported browser * Fix broken build * Update package-lock.json * Add TODO * Break dictation interims to its own component * Update TODOs * Cleanup * Don't parallel build * Incorporate PR changes * Add quick speak test * Update package-lock.json * Sample: group timestamp (microsoft#1189) * Group timestamp sample * Update README.md * Add backchannel sample (microsoft#1191) * Fix playground not building on Docker (microsoft#1197) * Add React sample (microsoft#1200) * Add language (microsoft#1206) * Fix URL parsing in modern browsers (microsoft#1213) * Numerous fixes for playground (microsoft#1214) * Carousel should show on dev mode speak activity * Default language should read from window.navigator.language * Lerna version should use exact version (microsoft#1219) * Honor locale on speech recognition and synthesis (microsoft#1220) * Option to hide timestamp * Prefer user ID from token * Remove username * Minor update to pl-Pl localization (microsoft#1225) * Add alt text * Add nb-NO (microsoft#1203) * Simplify Provider/connect and hide Redux (microsoft#1222) * Simplify Provider/connect and hide Redux * Use latest Web Chat in samples * Flatten Redux store * Rename upsertActivity to incomingActivity * Add TODO * Rename action family * Rename speech input to dictate * Update package-lock.json * Move serve.json to root * Fixing samples * Revisit all breakaway components to make sure they are easy to recompose (microsoft#1226) * Simplify Provider/connect and hide Redux * Flatten Redux store * Rename upsertActivity to incomingActivity * Rename action family * Simplify show/hide activities/timestamps * Expose UI and fix propTypes * Expose more UI components * Exposing more UIs * Add breakaway speech button sample * Making breakaway components more easy to reuse * Move to connectWithContext and remove withStyleSet * Fix build break * Move all to connectWithContext * Move Basic* to top-level and un-expose Context * Fix styleSet null * Rename activity2 to activity * Cleanup * Cleanup * Move default store to Composer * Add custom UI * Remove speech only button demo from playground * Cleanup * Update README.md * Update README.md * Update package-lock.json * Fix build break * Remove package-lock.json from samples * Add build script for breakaway speech button * Rename connectWithContext to connectToWebChat * Clean up * Bundling package-lock.json for npm ci * Corinagum/preview samples (microsoft#1235) * Update full-bundle README.md * Add more details and code snippets to full-bundle sample * minor edits to full-bundle readme * Clean up full-bundle readme * some minor edits + integrate with react README * Add README file to speech cognitive services sample * insignificant updates to previous samples * fix reference to wrong file * add speech browser sample * Add minimal bundle sample readme * README PR fixes & update CHANGELOG * reduce changelog line's character count * Adding empty lines for clarity * Update README.md - Adding empty lines after header - Removing `## Description` because it convey no meanings - Consistent upper/lowercase for header title (First word uppercase, other lowercase) * Styling update - Also make sure header level are continuous and not discrete (# -> ## instead of # -> ###) * Styling * Styling * Styling * Stying * Accessibility pass using Keros (microsoft#1233) * Simplify Provider/connect and hide Redux * Flatten Redux store * Rename upsertActivity to incomingActivity * Rename action family * Expose UI and fix propTypes * Remove package-lock.json from samples * Add title attribute * Add alt/title * Use role="img" * Bundling package-lock.json for npm ci * Make cropped image accessible * Make carousel flipper accessible * Revert botchat.js URL change * Allow img alt tag in sanitizer * Clean up * Rename connectWithContext to connectToWebChat * Use unified selector * Render unknown file attachment * Style for carousel * Default to null * Remove padding for filler * Add landmark role * Fix scroll to bottom * Remove external * Bump to react-scroll-to-bottom@1.2.0 * Bump react-film to 1.1.0 * Bump to react-say@1.1.0 * Flipper aria-label * Button title text * Add "Starting..." * Remove redundant narrative * Focus indicator for Firefox * Fix uploading attachment not showing up * Hide scrollbar in Firefox * Fix broken upload * Accessibility fix * Revert targetting debug build * aria-label for input type="file" * Rename UploadAttachmentButton to UploadButton * Focus indicator high contrast mode * Add TODO * Cover instead of contains * Update package-lock.json * Fix build break (microsoft#1255) * Update README.md * Catch slow Direct Line response (microsoft#1254) * Embed version via bundle (microsoft#1256) * Embed version via bundle * Add variant * Sort tag order * Update tag name * Rename botchat-core to botchat-minimal * Fix samples (microsoft#1271) * Fix homepage for gh-pages * Move gh-pages * Move gh-pages * Add breakaway speech button * Use lerna for samples written in React (microsoft#1272) * Samples use lerna for linking * Change page title * Include package-lock.json * Last mile on GA (microsoft#1260) * Add LOCALIZATION.md * Clean up * Fix upload button fail because overriding props * Fix send button not working on click * Guess MIME type for send files to preview photos * Customizable send timeout and default to 20s * Update package-lock.json * Fix audio card null ref on styleSet * Reset the branch * Update package-lock.json * Change preview branch to master branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MockBot is updated to support tamper-proof user ID. This PR update Web Chat playground to fetch user ID from MockBot. This will support OAuth "magic code"-free approach.
https://blog.botframework.com/2018/09/01/using-webchat-with-azure-bot-services-authentication/
https://blog.botframework.com/2018/09/25/enhanced-direct-line-authentication-features/