Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide upload button thru style options #1491

Merged
merged 3 commits into from
Dec 13, 2018

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Dec 13, 2018

Fix #1383

Background

This work will hide the file upload button from send box UI. It will not affect the file upload functionality if triggered via other means, e.g. via React context or Redux store.

When specified thru styleOptions.hideUploadButton, send box UI will not display upload button.

Changelog

Added

Samples

@coveralls
Copy link

Pull Request Test Coverage Report for Build 601

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 44.697%

Totals Coverage Status
Change from base Build 598: 0.05%
Covered Lines: 715
Relevant Lines: 1426

💛 - Coveralls

@a-b-r-o-w-n a-b-r-o-w-n self-requested a review December 13, 2018 17:14
@compulim compulim merged commit 5ff1608 into microsoft:master Dec 13, 2018
@compulim compulim deleted the feat-hide-upload-button branch December 13, 2018 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants