Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1499 Fix screen reader handling of name, activity, and timestamp #1528

Merged
merged 3 commits into from
Dec 21, 2018
Merged

#1499 Fix screen reader handling of name, activity, and timestamp #1528

merged 3 commits into from
Dec 21, 2018

Conversation

corinagum
Copy link
Contributor

Fix #1499

@coveralls
Copy link

coveralls commented Dec 21, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 649

  • 11 of 11 (100.0%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 45.148%
Files with Coverage Reduction New Missed Lines %
packages/component/src/Localization/ru-RU.js 2 0.0%
Totals Coverage Status
Change from base Build 648: 0.2%
Covered Lines: 730
Relevant Lines: 1447
💛 - Coveralls

compulim
compulim approved these changes Dec 21, 2018
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
packages/component/src/Activity/CarouselFilmStrip.js Outdated Show resolved Hide resolved
packages/component/src/Activity/CarouselFilmStrip.js Show resolved Hide resolved
packages/component/src/Activity/StackedLayout.js Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@compulim compulim changed the title #1499 Fix screen reader handling of name, activity, & timestamp #1499 Fix screen reader handling of name, activity, and timestamp Dec 21, 2018
@corinagum corinagum merged commit 81b9e0a into microsoft:master Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compulim compulim compulim approved these changes

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@corinagum @coveralls @compulim