Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add messageBack support to suggested actions #1581

Merged
merged 8 commits into from
Jan 16, 2019

Conversation

corinagum
Copy link
Contributor

@corinagum corinagum commented Jan 11, 2019

Fix #1402

  • DirectLineJS has been bumped with messageBack support
  • Web Chat has been updated to allow messageBack suggested actions
  • Integration tests for Mock Bot's suggested-actions command have been added
  • image and title (what the button displays) are individually optional, but one or the other must be defined
  • displayText represents the optional response from the user when a suggested action is selected
  • text and value may be empty, in which case an empty suggested action is sent to the bot

image
Mock Bot with added suggested-actions
image
messageBack as JSON with display text.

@coveralls
Copy link

coveralls commented Jan 11, 2019

Pull Request Test Coverage Report for Build 760

  • 12 of 20 (60.0%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.0%) to 48.428%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/component/src/Utils/AdaptiveCardBuilder.ts 0 3 0.0%
packages/component/src/Attachment/AdaptiveCardRenderer.js 0 5 0.0%
Totals Coverage Status
Change from base Build 749: 3.0%
Covered Lines: 786
Relevant Lines: 1466

💛 - Coveralls

@corinagum corinagum changed the title [WIP] Add messageBack support to suggested actions Add messageBack support to suggested actions Jan 14, 2019
Copy link
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase master. There are lot so changes around saga.

CHANGELOG.md Outdated Show resolved Hide resolved
__tests__/suggestedActions.js Show resolved Hide resolved
__tests__/suggestedActions.js Show resolved Hide resolved
packages/component/src/SendBox/SuggestedActions.js Outdated Show resolved Hide resolved
@corinagum
Copy link
Contributor Author

@compulim @a-b-r-o-w-n I have pushed PR changes up. My tests pass locally, and I'm not sure why it's saying coverage went down since I added tests. I will check with @compulim in person to see if he has advice.

@corinagum
Copy link
Contributor Author

@compulim and @a-b-r-o-w-n please ignore above comment - after a slight delay the travis build updated to say there was a 3% increase, and that tests are passing.

@corinagum corinagum merged commit 77b466e into microsoft:master Jan 16, 2019
@corinagum corinagum deleted the corinagum/messageBack branch February 18, 2019 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants