Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename sendTyping to sendTypingIndicator and add deprecation notes #1584

Merged
merged 11 commits into from
Jan 27, 2019
Merged

Rename sendTyping to sendTypingIndicator and add deprecation notes #1584

merged 11 commits into from
Jan 27, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Jan 13, 2019 •
edited
Loading

In draft mode because this PR requires merge of #1541.

Background

sendTypingIndicator is a better name for sending user's typing activity.

We are modifying a few areas in our code: actions, props, reducers, sagas, selectors. And adding a deprecation notes to them.

We will complete the deprecation and remove the code on 2020 January.

@coveralls
Copy link

coveralls commented Jan 13, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 861

  • 24 of 31 (77.42%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+1.6%) to 48.902%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/src/sagas/sendTypingIndicatorOnSetSendBoxSaga.js 7 8 87.5%
packages/component/src/Composer.js 7 10 70.0%
packages/core/src/reducers/sendTypingIndicator.js 6 9 66.67%
Files with Coverage Reduction New Missed Lines %
packages/core/src/actions/setSendTyping.js 1 50.0%
Totals Coverage Status
Change from base Build 860: 1.6%
Covered Lines: 817
Relevant Lines: 1522
💛 - Coveralls

@corinagum corinagum added this to Review in 4.3 Prioritization Jan 23, 2019
@compulim compulim added 4.3 p2 Nice to have and removed Pending labels Jan 23, 2019
@compulim compulim changed the title [DRAFT] Rename sendTyping to sendTypingIndicator and add deprecation notes Rename sendTyping to sendTypingIndicator and add deprecation notes Jan 23, 2019
corinagum
corinagum reviewed Jan 23, 2019
View reviewed changes
packages/component/src/Composer.js Outdated Show resolved Hide resolved
packages/component/src/Composer.js Outdated Show resolved Hide resolved
packages/core/src/index.js Outdated Show resolved Hide resolved
packages/core/src/reducer.ts Outdated Show resolved Hide resolved
packages/core/src/reducers/sendTypingIndicator.js Outdated Show resolved Hide resolved
samples/07.b.customization-send-typing-indicator/index.html Outdated Show resolved Hide resolved
packages/component/src/Composer.js Outdated Show resolved Hide resolved
packages/component/src/Composer.js Outdated Show resolved Hide resolved
packages/component/src/Composer.js Outdated Show resolved Hide resolved
packages/core/src/actions/setSendTyping.js Show resolved Hide resolved
@cwhitten
Copy link
Member

@compulim let's address the coverage and get this merged

@compulim compulim merged commit 39c3edc into microsoft:master Jan 27, 2019
4.3 Prioritization automation moved this from Review to Done Jan 27, 2019
@compulim compulim deleted the deprecate-send-typing branch January 27, 2019 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum left review comments

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees

@compulim compulim

Labels
p2 Nice to have
Projects
No open projects
4.3 Prioritization
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@compulim @coveralls @cwhitten @corinagum