Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample: Add hybrid speech sample #1617

Merged
merged 8 commits into from
Jan 23, 2019
Merged

Sample: Add hybrid speech sample #1617

merged 8 commits into from
Jan 23, 2019

Conversation

compulim
Copy link
Contributor

Fix #1597.

This PR add a sample of combining two speech engines:

  • Speech-to-text: speech engine from the browser
  • Text-to-speech: Cognitive Services Speech Services engine

@compulim compulim added the Sample Implement PoC or sample code label Jan 19, 2019
@compulim compulim mentioned this pull request Jan 19, 2019
Closed
@coveralls
Copy link

coveralls commented Jan 19, 2019 •
edited

Pull Request Test Coverage Report for Build 842

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 47.182%
Totals Coverage Status
Change from base Build 834: 0.0%
Covered Lines: 790
Relevant Lines: 1510
💛 - Coveralls

@corinagum
Copy link
Contributor

Please add README.md :) I can help with edits.

corinagum
corinagum suggested changes Jan 22, 2019
View reviewed changes
samples/06.f.hybrid-speech/index.html Outdated Show resolved Hide resolved
samples/06.f.hybrid-speech/index.html Outdated Show resolved Hide resolved
samples/06.f.hybrid-speech/index.html Outdated Show resolved Hide resolved
samples/06.f.hybrid-speech/index.html Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@compulim
Copy link
Contributor Author

@corinagum added README.md and fixed comments.

corinagum
corinagum reviewed Jan 23, 2019
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks doing the README.md 👍 I added a few questions, will approve after we discuss.

samples/06.f.hybrid-speech/README.md Outdated Show resolved Hide resolved
samples/06.f.hybrid-speech/README.md Outdated Show resolved Hide resolved
samples/06.f.hybrid-speech/README.md Outdated Show resolved Hide resolved
@compulim
Apply suggestions from code review
62f2669 
Co-Authored-By: compulim <compulim@users.noreply.github.com>
@compulim compulim merged commit ef62e21 into microsoft:master Jan 23, 2019
@compulim compulim deleted the sample-hybrid-speech branch January 23, 2019 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
Sample Implement PoC or sample code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@compulim @coveralls @corinagum