Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump react-film@1.1.2 and react-scroll-to-bottom@1.3.0 #1621

Merged
merged 2 commits into from
Jan 22, 2019
Merged

Bump react-film@1.1.2 and react-scroll-to-bottom@1.3.0 #1621

merged 2 commits into from
Jan 22, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Jan 22, 2019 •
edited
Loading

This will fix React warnings for suggested actions and improve reliability of scroll to bottom feature.

Changelog

Changed

@coveralls
Copy link

coveralls commented Jan 22, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 808

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 47.814%
Totals Coverage Status
Change from base Build 796: 0.5%
Covered Lines: 794
Relevant Lines: 1496
💛 - Coveralls

a-b-r-o-w-n
a-b-r-o-w-n approved these changes Jan 22, 2019
View reviewed changes
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@corinagum corinagum merged commit be8564c into microsoft:master Jan 22, 2019
@compulim compulim mentioned this pull request Feb 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@compulim @coveralls @a-b-r-o-w-n @corinagum