-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend style options to support basic adaptive cards style #1670
Extend style options to support basic adaptive cards style #1670
Conversation
default: { | ||
default: bubbleTextColor, | ||
subtle: subtle | ||
} | ||
} | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@compulim I'd like your opinion on this.
I made these changes based on the themes in Emulator. I think that allowing users to override the host config handles the extreme case of needing to fully customize the adaptive cards config. This change only passes a few things from the style options through.
Let me know what you think. We could extend this and add more options to styleOptions, but I thought that would not be necessary since the override already exists.
Pull Request Test Coverage Report for Build 915
💛 - Coveralls |
@compulim or @corinagum How should I proceed with the failing image snapshots? |
@a-b-r-o-w-n were there slight color changes? that's the only difference I can see in the snapshots. |
@corinagum ah. yes. probably because of this: https://github.com/Microsoft/BotFramework-WebChat/pull/1670/files#diff-27cc33be5272a601ab9ad5a925024b12R20. I'll revert that and see if it passes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you're waiting for @compulim's input. Just wanted to throw in that this looks good to me! We should definitely get this in before my ConnectivityStatus PR so that I can emulate these changes in the components I made.
Currently only passes font family and font colors through
Added
component
: Allow font family and adaptive cards text color to be set via styleOptions, by @a-b-r-o-w-n, in PR #1670