Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend style options to support basic adaptive cards style #1670

Merged
merged 9 commits into from
Feb 4, 2019

Conversation

a-b-r-o-w-n
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n commented Jan 30, 2019

Currently only passes font family and font colors through

Added

  • component: Allow font family and adaptive cards text color to be set via styleOptions, by @a-b-r-o-w-n, in PR #1670

default: {
default: bubbleTextColor,
subtle: subtle
}
}
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@compulim I'd like your opinion on this.

I made these changes based on the themes in Emulator. I think that allowing users to override the host config handles the extreme case of needing to fully customize the adaptive cards config. This change only passes a few things from the style options through.

Let me know what you think. We could extend this and add more options to styleOptions, but I thought that would not be necessary since the override already exists.

@coveralls
Copy link

coveralls commented Jan 31, 2019

Pull Request Test Coverage Report for Build 915

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • 12 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.08%) to 52.466%

Files with Coverage Reduction New Missed Lines %
packages/bundle/src/createDirectLine.js 3 20.0%
packages/component/src/Utils/TimeAgo.js 3 70.59%
packages/component/src/Utils/Timer.js 6 33.33%
Totals Coverage Status
Change from base Build 889: -0.08%
Covered Lines: 878
Relevant Lines: 1522

💛 - Coveralls

@a-b-r-o-w-n
Copy link
Contributor Author

@compulim or @corinagum How should I proceed with the failing image snapshots?

@corinagum
Copy link
Contributor

@a-b-r-o-w-n were there slight color changes? that's the only difference I can see in the snapshots.
https://webchattest.blob.core.windows.net/travis-result/2019/01/31/gy262/index.html
If that's the case, you can delete the failing images and run the tests locally again to push up the new png's. :)

@a-b-r-o-w-n
Copy link
Contributor Author

@corinagum ah. yes. probably because of this: https://github.com/Microsoft/BotFramework-WebChat/pull/1670/files#diff-27cc33be5272a601ab9ad5a925024b12R20. I'll revert that and see if it passes.

@compulim compulim mentioned this pull request Jan 31, 2019
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you're waiting for @compulim's input. Just wanted to throw in that this looks good to me! We should definitely get this in before my ConnectivityStatus PR so that I can emulate these changes in the components I made.

@a-b-r-o-w-n a-b-r-o-w-n merged commit 405af69 into microsoft:master Feb 4, 2019
4.3 Prioritization automation moved this from Review to Done Feb 4, 2019
@a-b-r-o-w-n a-b-r-o-w-n deleted the adaptive-card-styling branch February 4, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants