Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline UI - indicate slow connection and failed credentials #1679

Merged
merged 20 commits into from
Feb 4, 2019

Conversation

corinagum
Copy link
Contributor

@corinagum corinagum commented Jan 31, 2019

Resolves #1521

This adds a new component to the transcript that will notify the user when connectivity to the bot is taking longer than usual or has failed.
For slow connection, Web Chat will time 15 seconds before displaying the below warning:
image

A failed connection will be triggered when credentials are incorrect.
image

  • Update Italian localization, courtesy of andreo
  • @compulim, can you go through the Chinese localization files and add to FAILED_CONNECTION_NOTIFICATION and SLOW_CONNECTION_NOTIFICATION? I'll update my PR with your changes.

@coveralls
Copy link

coveralls commented Jan 31, 2019

Pull Request Test Coverage Report for Build 941

  • 31 of 34 (91.18%) changed or added relevant lines in 11 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.1%) to 54.201%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/component/src/Activity/SendStatus.js 0 1 0.0%
packages/core/src/reducers/connectivityStatus.js 12 14 85.71%
Totals Coverage Status
Change from base Build 937: 1.1%
Covered Lines: 923
Relevant Lines: 1552

💛 - Coveralls

@cwhitten
Copy link
Member

cwhitten commented Feb 1, 2019

@corinagum can you provide some screenshots in the descriptions of the pull request? thanks.

Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one missing semicolon, but other than that looks good!

@cwhitten
Copy link
Member

cwhitten commented Feb 4, 2019

@mewa1024 @DesignPolice given that WebChat isn't a public facing name given to the Chat window, should we make the copy more generic? Take BuzzFeed's recent Zo bot. It would be odd to see "WebChat" in error/warning copy here. But I could imagine more generic copy that doesn't call out WebChat specifically.

@mewa1024
Copy link

mewa1024 commented Feb 4, 2019

@cwhitten Good point. How about changing the messages to "Taking longer than usual to connect" and "Unable to connect"? @DesignPolice, thoughts?

@DesignPolice
Copy link

@cwhitten @mewa1024 @corinagum - That is true Chris, I forget that we need to be more generic with so many different uses of our product. That seems fine to me Mewa.

@corinagum
Copy link
Contributor Author

I'll update the copy shortly!

@corinagum
Copy link
Contributor Author

Update: I've updated the copy and fixed the build, but I'm having trouble getting tests to run locally so that I can update the png's for the ConnectivityStatus tests. Will check back in a bit.

@corinagum corinagum merged commit 9d738b7 into microsoft:master Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants