Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide suggested actions not destinated to the user #1706

Merged
merged 6 commits into from
Feb 9, 2019
Merged

Hide suggested actions not destinated to the user #1706

merged 6 commits into from
Feb 9, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Feb 7, 2019 •
edited
Loading

Fix #1057

Background

Suggested actions (spec here) can specify to field to show the suggested actions only for a set of users.

Today, we did not filter suggested actions based on the to field.

This fix will not show suggested actions with a to field targeting another user. For backward compatibility reason, if the to field is empty or not defined, we will continue to show suggested actions.

Changelog

Fixed

  • Fix #1057. Fixed suggested actions destinated for other recipients should not show up, by @compulim in PR #1706

@compulim compulim added the 4.3 label Feb 7, 2019
@coveralls
Copy link

coveralls commented Feb 7, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.6%) to 53.843% when pulling 57064d4 on compulim:feat-suggested-actions-for-others into 2d438d8 on Microsoft:master.

a-b-r-o-w-n
a-b-r-o-w-n reviewed Feb 7, 2019
View reviewed changes
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor nit

CHANGELOG.md Outdated Show resolved Hide resolved
@a-b-r-o-w-n a-b-r-o-w-n added this to Review in 4.3 Prioritization via automation Feb 7, 2019
4.3 Prioritization automation moved this from Review to In-Flight Feb 7, 2019
corinagum
corinagum suggested changes Feb 7, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
__tests__/suggestedActions.js Outdated Show resolved Hide resolved
tonyanziano
tonyanziano approved these changes Feb 7, 2019
View reviewed changes
__tests__/suggestedActions.js Outdated Show resolved Hide resolved
Corina and others added 3 commits February 7, 2019 12:45
@compulim
Apply suggestions from code review
b48c48f 
Co-Authored-By: compulim <compulim@users.noreply.github.com>
@compulim
Tag with core
70cfacd
@compulim
Adding snapshot
496b519
@compulim compulim moved this from In-Flight to Review in 4.3 Prioritization Feb 8, 2019
@compulim compulim removed this from Review in 4.3 Prioritization Feb 8, 2019
justinwilaby
justinwilaby approved these changes Feb 8, 2019
View reviewed changes
Copy link

@justinwilaby justinwilaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming the build failure is addressed.

@cwhitten cwhitten merged commit 9cc3c85 into microsoft:master Feb 9, 2019
@compulim compulim deleted the feat-suggested-actions-for-others branch February 9, 2019 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n left review comments

@justinwilaby justinwilaby justinwilaby approved these changes

@tonyanziano tonyanziano tonyanziano approved these changes

@corinagum corinagum corinagum approved these changes

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SuggestedActions that are accidentally sent to the bot are being rendered for the user
7 participants
@compulim @coveralls @justinwilaby @tonyanziano @a-b-r-o-w-n @corinagum @cwhitten