Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1625: Update root README.md and SAMPLES.md #1752

Merged
merged 3 commits into from
Feb 25, 2019
Merged

#1625: Update root README.md and SAMPLES.md #1752

merged 3 commits into from
Feb 25, 2019

Conversation

corinagum
Copy link
Contributor

@corinagum corinagum commented Feb 22, 2019 •
edited

Fix #1625

  • Update default user information - Web Chat will now generate a random id.
  • Add rootHeight and rootWidth styling examples in SAMPLES.md

new screen caps:

Screenshot of Web Chat

Web Chat with rootHeight and rootWidth set

compulim
compulim approved these changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@compulim compulim left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merge, could you update the image without the black border. I would suggest using some photo editing tools to crop accurately.

If you don't have any tools around, please commit the PNG image in the source branch so we can work on it later. The image uploaded by CTRL + V is not editable.

Also, the resolution on the image seems wrong, it looks pretty blurry in 100%.

@corinagum corinagum merged commit b95462b into microsoft:master Feb 25, 2019
@corinagum
Copy link
Contributor Author

Merged this in since Travis build said it passed but GH didn't update

@corinagum corinagum mentioned this pull request Feb 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compulim compulim compulim approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@corinagum @compulim