Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1523 Offline UI - connecting for the first time #1866

Merged
merged 10 commits into from
Apr 4, 2019

Conversation

corinagum
Copy link
Contributor

@corinagum corinagum commented Apr 3, 2019

Resolves #1524
Fix #1856

This now brings 'Connecting...' text to Web Chat when connecting for the first time.

Scenario 1: User connects to Web Chat for the first time, and 'Connecting...' disappears after connection via DirectLine is made.
ezgif-5-a2cbe28dddf0

Scenario 2: User connects to Web Chat for the first time, and 'Connecting...' shows until it changes to 'Taking longer than usual to connect'
Media2

(difference in quality is due to making the gifs on different websites)

Notes

  • Because of the possibility of 'Connecting...' showing extremely briefly, I added a 400ms pause that keeps the text on screen for a little bit after connection is made.

@coveralls
Copy link

coveralls commented Apr 3, 2019

Coverage Status

Coverage increased (+0.7%) to 52.637% when pulling e9d7b67 on corinagum:corinagum/offlineUI-1523 into 4968998 on Microsoft:master.

Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor style nitpicks. Looks good!

@corinagum corinagum merged commit 7240ad9 into microsoft:master Apr 4, 2019
@Souvik04
Copy link

I can see the connecting loader appears briefly. I have a scenario where I use a back channel activity to post data to user as a welcome message. Sometimes, the message might take a while to appear in the conversation window. Is there a way to wait for the back channel post back welcome message and show the connecting loader until then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customize Web Chat with Reaction Buttons does not work Need offline UI: Connecting for the first time
4 participants