Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CSS collisions with Bootstrap and bump memoize-one #1884

Merged
merged 4 commits into from
Apr 9, 2019
Merged

Fix CSS collisions with Bootstrap and bump memoize-one #1884

merged 4 commits into from
Apr 9, 2019

Conversation

corinagum
Copy link
Contributor

@corinagum corinagum commented Apr 9, 2019 •
edited
Loading

Fixes #1837
Fixes #1643

  • End collision of external styles like Bootstrap by changing the .row class in Web Chat to .webchat__row
  • Bump memoize-one

@compulim
Copy link
Contributor

compulim commented Apr 9, 2019

I am thinking to convert it to BEM naming convention, i.e. webchat__row.

But if @cwhitten is okay with the current one, webchat-row, then let's hit this first and then go to BEM later.

@coveralls
Copy link

coveralls commented Apr 9, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 52.723% when pulling b91d3df on corinagum:1837 into e561bc4 on Microsoft:master.

@corinagum corinagum merged commit c2f9021 into microsoft:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhitten cwhitten cwhitten approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@compulim compulim Awaiting requested review from compulim compulim is a code owner

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@corinagum @compulim @coveralls @cwhitten