#1525 Add "Render error" connectivity status for JavaScript errors. #1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corinagum
requested review from
a-b-r-o-w-n,
compulim,
cwhitten,
justinwilaby and
tonyanziano
as code owners
tonyanziano
reviewed
Apr 25, 2019
tonyanziano
reviewed
Apr 25, 2019
tonyanziano
reviewed
Apr 25, 2019
corinagum
changed the title
tonyanziano
previously approved these changes
Apr 25, 2019
|
New test is failing. I am investigating - sorry for the delay. |
cwhitten
reviewed
Apr 27, 2019
| const scriptElement = document.createElement('script'); | ||
| setup: () => | ||
| Promise.all([ | ||
| window.WebChatTest.loadScript('https://unpkg.com/core-js@2.6.3/client/core.min.js'), |
There was a problem hiding this comment.
why are we installing these dependencies inline with the tests? is there another purpose than this?
There was a problem hiding this comment.
We want to mock DirectLineJS in this test. And DirectLineJS use Observable. Thus, we need to temporarily include core-js in the browser to provide Observable for us to mock DLJS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #1525
createStorein the Web Chat API Reference