Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Adaptive Cards to bundle #1936

Merged
merged 3 commits into from
May 6, 2019
Merged

Move Adaptive Cards to bundle #1936

merged 3 commits into from
May 6, 2019

Conversation

corinagum
Copy link
Contributor

@corinagum corinagum commented Apr 29, 2019 •
edited

Fix #1302
Continuation of #1304, originally @compulim's work :)

This moves Adaptive Cards from core to bundle.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 57.922% when pulling 5326ba6 on corinagum:1304-AC-to-bundle into 0001b8e on Microsoft:master.

@corinagum
Copy link
Contributor Author

corinagum commented Apr 29, 2019 •
edited

Tests are timing out for some reason. :/ Restarting build.

@corinagum corinagum added 4.5 PR: On hold For PR's placed on the backburner labels Apr 29, 2019
@corinagum corinagum merged commit 2948e96 into microsoft:master May 6, 2019
@corinagum corinagum added this to Done in R8 Prioritization May 13, 2019
@corinagum corinagum removed the PR: On hold For PR's placed on the backburner label May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compulim compulim compulim approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
No open projects
R8 Prioritization
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Adaptive Cards attachment renderer to bundle
3 participants
@corinagum @coveralls @compulim