Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a layer of URLSearchParams #1938

Merged
merged 3 commits into from
Apr 30, 2019
Merged

Remove a layer of URLSearchParams #1938

merged 3 commits into from
Apr 30, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Apr 29, 2019 •
edited

Edge fails if new URLSearchParams(new URLSearchParams()), but Chrome and Firefox passed.

We should remove the extra new URLSearchParams() here.

@compulim compulim added the 4.4 label Apr 29, 2019
@coveralls
Copy link

coveralls commented Apr 29, 2019 •
edited

Coverage Status

Coverage decreased (-0.04%) to 58.114% when pulling b4b4431 on compulim:fix-embed-edge into 0001b8e on Microsoft:master.

@compulim
Copy link
Contributor Author

@corinagum I tested this PR and it fixed the problem.

@corinagum corinagum merged commit 8ef6e55 into microsoft:master Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@compulim @coveralls @corinagum