Added pt-PT localization. #2015
Conversation
tiagodenoronha
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten,
justinwilaby and
tonyanziano
as code owners
There was a problem hiding this comment.
- Please add your name to the LOCALIZATION.md :)
- Earlier today, @bodyzatva merged in his own version of this file on this PR: Update pt-PT.js #2005. Could both of you collaborate to compromise on the differences?
|
Yep, let me check out what he did and get him on board with the changes aswell! |
|
Merged the changes onto the PR. Yet, I found this behaviour when trying to figure out when the message was sent, shouldn't that be localized? (Image for reference)
@bodyzatva can you give it a look and check if it's ok? :) |
| 'Speak': 'Falar', | ||
| 'Starting…': 'A iniciar…', | ||
| 'Starting…': 'A iniciar...', |
There was a problem hiding this comment.
Could you switch this back to '…' (single character)
There was a problem hiding this comment.
marked as unresolved; the ellipses is still three characters.
There was a problem hiding this comment.
Wait, I definitely need help with Github.. It shows me like I did: 1b62894
There was a problem hiding this comment.
Hmm, and the branch on my repo appears good as well... https://github.com/tiagodenoronha/BotFramework-WebChat/blob/patch-1/packages/component/src/Localization/pt-PT.js
There was a problem hiding this comment.
Okay that's odd.
So I have some bad news, haha. There's going to be a PR this week that will cause merge conflicts with this PR. Do you mind if we put this on hold for a couple days, and I can alert you when the new PR is in? That way you can branch off of the new master and incorporate your changes, and hopefully this odd situation will resolve itself in the new PR. Does that sound ok? Sorry for the trouble!
|
That should definitely be localized. Let me look into this while we're waiting for confirmation from @bodyzatva. |
Changed ... to … (single char)
|
Sure, I can help no problem! Question is, how can I help? JS isn't exactly my top language to code in :) |
|
Oh no worries - we need to investigate why {retry} is showing instead of the localization, but if you aren't able to then I will get to it eventually -- hopefully by the end of next week :) |
|
Sorry! When it comes to js, I'm more of a "bother" than a "helper" :) |
|
No problem. Could you let me know what reproduction steps you're using to get the Send failed message? That will help a lot! |
|
That one is easy! Spin up bot framework emulator, and send a message with pt-BR locale. If I'm not mistaken, the Bot Framework Emulator uses Webchat behind the scenes, so if it happens there, it happens here :) |
|
Ah in that case, I think we expect it to fail since pt-BR is not available on Emulator's version of Web Chat. I'll investigate a little more soon and get back to this PR. Thanks for the help :) Did you intend on updating both pt-PT and pt-BR? |
|
I didn't, only pt-PT, did I update both by mistake? |
|
Hey @tiagodenoronha, sorry for the confusion. Let's try to clear things up before proceeding. :)
|
|
|
@tiagodenoronha this is your final changes? i need this changes for my project :) |
|
@bodyzatva and @tiagodenoronha, sorry for the delay! I think I figured out the issue (it was a separate bug) and will have the fix up hopefully this week. I will keep you guys updated if anything changes. Thanks for your patience! |
|
Hey @corinagum , did you check my comments? :) |
|
@tiagodenoronha, sorry for the trouble but the new merge is in. Would you mind opening a new PR with your changes? Hopefully that will resolve the non-updating commits as well. |
|
Hey no problem! Give me a couple of days and I'll send you a new PR! :) |
Description
Adding localized strings for pt-PT