Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 1876 a11y #2018

Merged
merged 8 commits into from
May 28, 2019
Merged

Fix 1876 a11y #2018

merged 8 commits into from
May 28, 2019

Conversation

corinagum
Copy link
Contributor

@corinagum corinagum commented May 21, 2019 •
edited
Loading

Fixes #1876

Changelog Entry

Description

This was an extended dive into a11y so that the Narrator, NVDA, and VoiceOver will only read changes in the transcript once

Specific Changes

  • Explicitly designate the aria-atomic and aria-relevant attributes
  • Remove nested live attributes
  • Remove timestamp from the "User sent __" and "Bot sent __" aria-label strings
  • Change aria-label of the component to be an absolute timestamp for the "xMinutesAgo" feature, but remain as "Sending" before send has completed. This will presumably prevent the screen reader from repeatedly updating all es in the transcript.
  • A chart confirming which browsers and what screen reader we expect Web Chat to work on.

compulim
compulim approved these changes May 28, 2019
View reviewed changes
Copy link
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just nitpicking.

CHANGELOG.md Outdated Show resolved Hide resolved
packages/component/src/Activity/Bubble.js Show resolved Hide resolved
packages/component/src/Activity/Timestamp.js Show resolved Hide resolved
corinagum and others added 2 commits May 28, 2019 14:57
@corinagum @compulim
Update CHANGELOG.md
d7faa0d 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
Remove duplicate code for aria-hidden
a1d913b
@corinagum corinagum merged commit f6f9767 into microsoft:master May 28, 2019
@corinagum corinagum mentioned this pull request Jul 5, 2019
Closed
@compulim compulim mentioned this pull request Jul 8, 2019
Closed
26 tasks
@cimbis cimbis mentioned this pull request Aug 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compulim compulim compulim approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Screen readers narrate all the messages from the beginning for every new message
2 participants
@corinagum @compulim