Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to prettier! #2038

Merged
merged 70 commits into from
Jun 3, 2019
Merged

Move to prettier! #2038

merged 70 commits into from
Jun 3, 2019

Conversation

corinagum
Copy link
Contributor

@corinagum corinagum commented May 29, 2019 •
edited
Loading

Fixes #1982

Changelog Entry

Specific Changes

  • Prettier is now incorporated into Web Chat
  • Every commit, prettier will run a linting pass. We may need to make some adjustments in the following days/weeks regarding how many files are parsed through on each commit.

@corinagum corinagum changed the title Feat prettier Move to prettier! May 29, 2019
compulim
compulim reviewed May 30, 2019
View reviewed changes
.eslintrc.yml Show resolved Hide resolved
SAMPLES.md Outdated Show resolved Hide resolved
SAMPLES.md Outdated Show resolved Hide resolved
__tests__/setup/conditions/actionDispatched.js Outdated Show resolved Hide resolved
__tests__/setup/conditions/allImagesLoaded.js Outdated Show resolved Hide resolved
__tests__/setup/retry.js Outdated Show resolved Hide resolved
__tests__/setup/setupTestEnvironment.js Outdated Show resolved Hide resolved
babel-jest-config.js Show resolved Hide resolved
packages/bundle/.eslintrc.yml Show resolved Hide resolved
packages/bundle/.eslintrc.yml Outdated Show resolved Hide resolved
corinagum and others added 2 commits May 30, 2019 10:10
@corinagum @compulim
Update /actionDispatched.js
3e9c673 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
@corinagum @compulim
Update packages/bundle/.eslintrc.yml
ea529c8 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
compulim
compulim approved these changes May 30, 2019
View reviewed changes
Copy link
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I filled out all the function names.

Consider I approved if you don't have any objections on my comments. If you do, feel free to ping me or talk to Chris.

packages/bundle/src/adaptiveCards/Styles/StyleSet/AnimationCardAttachment.js Outdated Show resolved Hide resolved
packages/bundle/src/adaptiveCards/Styles/StyleSet/AudioCardAttachment.js Outdated Show resolved Hide resolved
packages/component/.eslintrc.yml Show resolved Hide resolved
packages/component/src/Localization/da-DK.js Outdated Show resolved Hide resolved
packages/component/src/Middleware/concatMiddleware.js Outdated Show resolved Hide resolved
packages/core/src/sagas/submitSendBoxSaga.js Outdated Show resolved Hide resolved
packages/core/src/utils/getTimestamp.js Outdated Show resolved Hide resolved
packages/core/src/utils/sleep.js Outdated Show resolved Hide resolved
packages/core/src/utils/uniqueID.js Outdated Show resolved Hide resolved
packages/core/src/sagas/effects/forkPut.js Outdated Show resolved Hide resolved
compulim
compulim reviewed May 30, 2019
View reviewed changes
Copy link
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I filled out all the function names.

Consider I approved if you don't have any objections on my comments. If you do, feel free to ping me or talk to Chris.

corinagum and others added 11 commits May 30, 2019 12:53
@corinagum @compulim
Update submitSendBoxSaga.js
81d5433 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
@corinagum @compulim
Update getTimestamp.js
0130c58 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
@corinagum @compulim
Update sleep.js
22fe7ba 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
@corinagum @compulim
Update concatMiddleware.js
4b2456b 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
@corinagum @compulim
Update uniqueID.js
d61fc2a 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
@corinagum @compulim
Update forkPut.js
7f4d315 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
@corinagum @compulim
Update AudioAttachment.js
3d4f05c 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
@corinagum @compulim
Update AudioContent.js
dc9eb01 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
@corinagum @compulim
Update CarouselFilmStrip.js
d14dfdf 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
@corinagum @compulim
Update retry.js
6301a95 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
@corinagum @compulim
Update allImagesLoaded.js
64ca6c7 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
corinagum and others added 25 commits May 30, 2019 14:49
@corinagum @compulim
Update VideoContent.js
42434fe 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
@corinagum @compulim
Update VimeoContent.js
d9c4120 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
@corinagum @compulim
Update WarningNotification.js
bcdca4b 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
@corinagum @compulim
Update StyleSet/YouTubeContent.js
b9bb884 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
@corinagum @compulim
Update Utils/debounce.js
66bc7b4 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
@corinagum @compulim
Update Utils/shallowEquals.js
28d0698 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
@corinagum @compulim
Update textFormatToContentType.js
64246e9 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
@corinagum @compulim
Update connectionStatusUpdate.js
da1a33e 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
@corinagum @compulim
Update deleteActivity.js
005ddf4 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
@corinagum @compulim
Update disconnect.js
bd8ec7f 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
@corinagum @compulim
Update incomingActivity.js
1f9e42e 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
@corinagum @compulim
Update packages/core/src/actions/postActivity.js
467410c 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
@corinagum @compulim
Update packages/core/src/actions/sagaError.js
f8880f5 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
@corinagum @compulim
Update packages/core/src/actions/setDictateInterims.js
3e35790 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
@corinagum @compulim
Update packages/core/src/actions/setDictateState.js
3830db7 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
@corinagum @compulim
Update packages/core/src/actions/setSendBox.js
8db7bfa 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
@corinagum @compulim
Update packages/core/src/actions/setSendTyping.js
359341e 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
@corinagum @compulim
Update packages/core/src/actions/setSendTypingIndicator.js
a0dca38 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
@corinagum @compulim
Update packages/core/src/actions/startDictate.js
cab0905 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
@corinagum @compulim
Update packages/core/src/actions/stopDictate.js
3229048 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
@corinagum @compulim
Apply function names from code review
961a9ac 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
Linting after PR Fixes
6baf89e
Remove .md files from prettier and add manual .md file command
6386e6c
Remove timestamp from localization params
834b6e1
Fix merge conflict on CHANGELOG.md
e7b791d
tonyanziano
tonyanziano approved these changes Jun 3, 2019
View reviewed changes
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@corinagum corinagum merged commit a10096a into microsoft:master Jun 3, 2019
@corinagum corinagum mentioned this pull request Jun 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compulim compulim compulim approved these changes

@tonyanziano tonyanziano tonyanziano approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move to Prettier
3 participants
@corinagum @compulim @tonyanziano