Fixed markdown renderer in Playground #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
approved these changes
Jun 12, 2019
tdurnford
requested review from
a-b-r-o-w-n,
cwhitten,
justinwilaby and
tonyanziano
as code owners
|
Thanks @tdurnford |
corinagum
pushed a commit
to corinagum/BotFramework-WebChat
that referenced
this pull request
Jun 19, 2019
* Fixed markdown renderer in Playground * Updated CHANGELOG.md * Fixed markdown renderer in Playground * Updated CHANGELOG.md * Modified renderMarkdown function
corinagum
added a commit
that referenced
this pull request
Jun 19, 2019
* Fixed markdown renderer in Playground (#2073) * Fixed markdown renderer in Playground * Updated CHANGELOG.md * Fixed markdown renderer in Playground * Updated CHANGELOG.md * Modified renderMarkdown function * Committed by gittest2.js - v-bruhal * Delete dummy.txt * Committed by gittest2.js - v-bruhal * Delete dummy.txt * Committed by gittest2.js - v-bruhal * Delete dummy.txt * Delete backend cli sampl * Add IE11 sample compatibility notes to root and ES5 README (#2088) * Add remark and strip-markdown * use strip-markdown to form aria text * Update CHANGELOG.md * Apply suggestions from code review Co-Authored-By: William Wong <compulim@users.noreply.github.com> * Add readme revisions * Rename variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2069
Changelog Entry
Fix #2069. Fixed markdown renderer issue in Playground, by @tdurnford in PR#xxx
Specific Changes
Updated the Playground to use Web Chat's default markdown renderer. Also made slight modification to the FullReactWebChat component to ensure the attachment middleware isn't falling back to the default markdown renderer when the developer chooses to use their own renderer.