Increase timeouts.directLine from 5000 to 15000 #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BruceHaley
requested review from
a-b-r-o-w-n,
cwhitten,
justinwilaby and
tonyanziano
as code owners
|
I believe this one will not work 90% of the time. It is because if Web Chat did not receive the message within 5 seconds, Web Chat probably won't receive the message within 15 seconds. It was because, most of the time, the message is lost in space. Retry will make it more reliable, we set retry to 3 times now. |
|
After discussing offline, this may makes sense because the network infrastructure on VSTS hosted agent may be much slower than our previous agent. And 15s might fix a few issues. Anyway, we will have #1680 to move Mockbot inside a browser, so we will skip the public Direct Line infrastructure. This could be ultimate fix for this. |
compulim
reviewed
Jun 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 4 tests timing out in BotFramework-WebChat-CI-PR.