Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scroll stickiness issue with Adaptive Card and suggested actions #2107

Merged
merged 3 commits into from
Jun 23, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Jun 21, 2019

Fixes #1926.

Changelog Entry

  • Fix #1926. Fixed scroll stickiness issue when submitting an Adaptive Card form with suggested actions opened, by @compulim in PR #2107

Description

Bringing 2 commits from react-scroll-to-bottom:

  • Their PR #24, fixed synthetic scroll events crafted by Chrome should not cause stickiness to lose
  • Their PR #22, bumped development dependencies for security vulnerabilities

Specific Changes

Bumped react-scroll-to-bottom to 1.3.2.


  • Tests added

@compulim compulim requested a review from corinagum June 21, 2019 00:04
@compulim
Copy link
Contributor Author

@corinagum I added a new WebDriver condition named scrollToBottomCompleted. This can be used to help improve our test reliability.

await driver.wait(scrollToBottomCompleted(), timeouts.scrollToBottom);

@compulim compulim marked this pull request as ready for review June 21, 2019 01:49
@compulim compulim force-pushed the bump-react-scroll-to-bottom branch from d511c23 to 4b93f2a Compare June 21, 2019 01:54
@corinagum
Copy link
Contributor

@tdurnford, do we want to implement the new scrollToBottomCompleted into any of our previous tests?

@tdurnford
Copy link
Contributor

Yea we probably want to update this line to use the new scrollToBottom timeout instead of making the driver sleep for a second.

@corinagum
Copy link
Contributor

@tdurnford please either file an issue or submit a PR :D

@corinagum corinagum merged commit 4d56088 into microsoft:master Jun 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scroll event is not triggering every time a message is received
3 participants