Fix Speech speaking the title, subtitle, and text of cards #2118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corinagum
requested review from
a-b-r-o-w-n,
compulim,
cwhitten,
justinwilaby and
tonyanziano
as code owners
tdurnford
reviewed
Jun 24, 2019
compulim
approved these changes
Jun 25, 2019
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Description
In v3 of Web Chat, Speech did not read out title, subtitle, and text of cards. This fix brings parity back to that version. Previously, Speech in v4 would speak all three and cause 'doubling' of spoken text.
Behavior on mobile:
keyboard closes when sending via the send button
if keyboard is closed, it stays closed when sending via the send button
if sending via 'return' or 'enter' when the keyboard is open, the keyboard stays open.
Testing Added
No testing added since this is a speech change.