-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample: Single sign-on for Intranet apps #2144
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corinagum
approved these changes
Jul 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending some comments. Also, check out the build. :)
samples/19.b.single-sign-on-for-intranet-apps/web/public/index.html
Outdated
Show resolved
Hide resolved
samples/19.b.single-sign-on-for-intranet-apps/web/public/index.html
Outdated
Show resolved
Hide resolved
samples/19.b.single-sign-on-for-intranet-apps/web/src/generateDirectLineToken.js
Outdated
Show resolved
Hide resolved
Co-Authored-By: Corina <14900841+corinagum@users.noreply.github.com>
compulim
added a commit
to compulim/BotFramework-WebChat
that referenced
this pull request
Jul 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2133.
Changelog Entry
*
: Single sign-on for Intranet apps, by @compulim in #2144Description
You can try out the hosted live demo at https://webchat-sample-sso-intranet.azurewebsites.net/.
Add another SSO sample for "silent access token retrieval" based on the existing "19.a" sample. This sample is significantly simpler in code because it does not have any UI parts and does not support SPA.
Specific Changes
samples/19.b.single-sign-on-for-intranet-apps
.[ ] Testing Added