Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic test for speech recognition and synthesis #2153

Merged
merged 25 commits into from
Jul 9, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Jul 8, 2019

Fixes #2122.

Changelog Entry

Description

Speech recognition and synthesis in Web Chat is not tested due to lack of test harness.

This work will add test harness so we can start testing speech functionality in Web Chat, along with basic tests for speech.

This work does not modify any production code.

Specific Changes

  • Added mockWebSpeech.js while loading the test harness page
    • Exposed as window.WebSpeechMock for required ponyfills and mock functions
  • Devs can ask the test harness for a couple of things
    • Recognize a single transcript
    • Recognize with unhappy paths (e.g. bird tweets or network error)
    • Get text that need to be synthesized
  • Tests added
    • Basic test for multiple turn for speech recognition and synthesis
    • Test for interrupting speech recognition via keyboard

  • Testing Added

Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments

__tests__/setup/web/mockWebSpeech.js Outdated Show resolved Hide resolved
__tests__/setup/web/mockWebSpeech.js Outdated Show resolved Hide resolved
__tests__/setup/web/mockWebSpeech.js Show resolved Hide resolved
@compulim compulim merged commit e8dc03d into microsoft:master Jul 9, 2019
@compulim compulim deleted the feat-speech-test-harness branch July 9, 2019 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add to test framework: the ability to emulate Web Speech
2 participants