Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move composer and connectToWebChat to React hooks and functional component #2308

Merged
merged 8 commits into from
Aug 22, 2019
Merged

Move composer and connectToWebChat to React hooks and functional component #2308

merged 8 commits into from
Aug 22, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Aug 13, 2019 •
edited
Loading

Changelog Entry

Changed

Description

Use React hooks for composer and connectToWebChat.

This paves the way for moving to useSelector et al. from react-redux. We are waiting for this PR from react-redux to go production.

Specific Changes

  • Bumps to react-redux@7.1.0
  • Composer.js would use React hooks with simplified memoization function
  • Updates to our multiple store strategy: instead of passing store as prop, we are passing a custom React context
  • Testing Added
    • No new features has been introduced

@compulim compulim marked this pull request as ready for review August 13, 2019 16:56
@coveralls
Copy link

coveralls commented Aug 16, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 66.137% when pulling 9af6a49 on compulim:feat-next-composer into 1e6b279 on microsoft:master.

@corinagum corinagum mentioned this pull request Aug 20, 2019
Merged
1 task
tdurnford
tdurnford reviewed Aug 21, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
packages/component/src/Composer.js Outdated Show resolved Hide resolved
packages/component/src/Composer.js Outdated Show resolved Hide resolved
corinagum
corinagum approved these changes Aug 21, 2019
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of my comments are redundant to TJ's, but one wasn't so I'm posting anyway xD

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
packages/component/src/Composer.js Outdated Show resolved Hide resolved
@corinagum corinagum mentioned this pull request Aug 21, 2019
Merged
1 task
@compulim compulim merged commit eb6aa67 into microsoft:master Aug 22, 2019
@compulim compulim deleted the feat-next-composer branch August 22, 2019 08:46
@compulim compulim mentioned this pull request Oct 25, 2019
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdurnford tdurnford tdurnford left review comments

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@compulim @coveralls @corinagum @tdurnford