Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added allowFullScreen prop to video content iframes #2399

Merged
merged 2 commits into from
Sep 13, 2019
Merged

Added allowFullScreen prop to video content iframes #2399

merged 2 commits into from
Sep 13, 2019

Conversation

tdurnford
Copy link
Contributor

Fixes #2398

Changelog Entry

Added full screen capability to iframes in the YouTubeContent and VimeoContent components by @tdurnford in PR #2399

Description

See Changelog entry

  • Testing Added

tdurnford
tdurnford commented Sep 13, 2019
View reviewed changes
Copy link
Contributor Author

@tdurnford tdurnford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM lol

corinagum
corinagum approved these changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W┴פ˥

compulim
compulim reviewed Sep 13, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@tdurnford @compulim
Update CHANGELOG.md
d2397f0 
Co-Authored-By: William Wong <compulim@users.noreply.github.com>
@coveralls
Copy link

coveralls commented Sep 13, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 65.201% when pulling c838dd5 on tdurnford:2398 into 9282174 on microsoft:master.

@tdurnford tdurnford merged commit 39a52cf into microsoft:master Sep 13, 2019
This was referenced Oct 25, 2019
Closed
Merged
corinagum pushed a commit that referenced this pull request Oct 29, 2019
@compulim @corinagum
Add tests for #2331, #2332, and #2399 (#2504)
aaadb89 
* Add test for #2331

* Add test for hiding scroll to bottom button

* Add test for YouTube full screen control

* Reliability

* Filter out DIRECT_LINE/CONNECT* actions

* Set payload.directLine to empty object

* Filter out payload.directLine

* Better filtering
@compulim compulim mentioned this pull request Dec 10, 2019
Closed
73 tasks
@corinagum corinagum mentioned this pull request Dec 13, 2019
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compulim compulim compulim approved these changes

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding allowfullscreen and frameborder attributes to YouTubeContent iframe
4 participants
@tdurnford @coveralls @compulim @corinagum