Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test reliability #2777

Merged
merged 16 commits into from
Dec 29, 2019
Merged

Improve test reliability #2777

merged 16 commits into from
Dec 29, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Dec 27, 2019 •
edited
Loading

Fixes #2612. Fixes #2653. Fixes #2691. Fixes #2737. Fixes #2776. Fixes #2483.

Changelog Entry

Fixed

  • Fixes the following issues and improves test reliability, by @compulim in PR #XXX
    • Fixes #2612. Wait until language change
    • Fixes #2653. Scroll-to-bottom check will do 5 consecutive checks to determine stickiness.
    • Fixes #2691. Wait until button is shown/hid before taking screenshot
    • Fixes #2737. Use driver.wait for conditions
    • Fixes #2776. Wait until button is shown/hid before taking screenshot
    • Use global timeout values

Description

Improve test reliability.

Specific Changes

See CHANGELOG.md for details.

  • Testing Added

@coveralls
Copy link

coveralls commented Dec 27, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 65.915% when pulling 2ed6c3e on compulim:feat-test-reliability into 31c2006 on microsoft:master.

corinagum
corinagum approved these changes Dec 28, 2019
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but please check out my comments before merging in. What do you think?

compulim and others added 2 commits December 30, 2019 03:08
@compulim @corinagum
Update __tests__/setup/conditions/scrollToBottomCompleted.js
f5f5a5b 
Co-Authored-By: Corina <14900841+corinagum@users.noreply.github.com>
@compulim
Rename to negationOf
2ed6c3e
@compulim compulim merged commit 3c78937 into microsoft:master Dec 29, 2019
@compulim compulim deleted the feat-test-reliability branch December 29, 2019 20:34
@compulim compulim mentioned this pull request Mar 5, 2020
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@compulim @coveralls @corinagum