Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11 anchors fixed to open securely without 'noreferrer' or 'noopener' #3607

Merged
merged 3 commits into from
Nov 17, 2020

Conversation

corinagum
Copy link
Contributor

@corinagum corinagum commented Nov 17, 2020

Fixes #3483

Changelog Entry

  • Fixes #3483. IE11 anchors fixed to open securely without 'noreferrer' or 'noopener', by @corinagum in PR #3607

Reference previous PR: #3224

Description

Due to 'noopener' not being available in IE11 (caniuse.com noopener), anchors opened in Internet Explorer were opening without scrolling and in a separate window. This fix securely opens links in Internet Explorer 11 without using 'noopener', with information used from https://mathiasbynens.github.io/rel-noopener/

This does not affect behavior in other browsers.

ezgif-ie11-windowOpen

  • I have added tests and executed them locally
    • We don't have IE11 tests
  • I have updated CHANGELOG.md
  • I have updated documentation

@corinagum
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@corinagum corinagum merged commit ad7997b into microsoft:master Nov 17, 2020
@compulim compulim mentioned this pull request Mar 2, 2021
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IE11 windows opened by Action.OpenUrl from an Adaptive Card is not resizable or scrollable
2 participants