Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify localization strings for carousel flippers #4646

Merged
merged 4 commits into from Feb 16, 2023

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Feb 16, 2023

Related to #4557.

Changelog Entry

Fixed

  • Fixes #4557. Flipper buttons in carousels and suggested actions is now renamed to "next/previous" from "left/right", by @compulim, in PR #4646

Description

This is a 2-part fix. This PR will add/change loc strings for the flipper buttons. The next PR will b ump the package.

Specific Changes

  • Updated en-US.json/yue.json
    • Renamed CAROUSEL_FLIPPER_LEFT_ALT to CAROUSEL_FLIPPER_PREVIOUS_ALT
    • Renamed CAROUSEL_FLIPPER_RIGHT_ALT to CAROUSEL_FLIPPER_NEXT_ALT
    • Added SUGGESTED_ACTIONS_FLIPPER_NEXT_ALT/SUGGESTED_ACTIONS_FLIPPER_PREVIOUS_ALT
    • "left" is now "previous", "right" is now "next"
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim added the p1 Painful if we don't fix, won't block releasing label Feb 16, 2023
@compulim compulim marked this pull request as ready for review February 16, 2023 19:26
beyackle2
beyackle2 previously approved these changes Feb 16, 2023
Copy link
Contributor

@beyackle2 beyackle2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read through it and it looks good.

@compulim compulim merged commit fa77780 into main Feb 16, 2023
@compulim compulim deleted the feat-flipper-next-previous branch February 16, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1 Painful if we don't fix, won't block releasing
Projects
None yet
2 participants