Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aria-hidden attributes from focusables #4659

Merged
merged 2 commits into from Mar 2, 2023
Merged

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Mar 2, 2023

Related to #4652.

Changelog Entry

Fixed

  • Fixes #4652. Keyboard help screen, activity focus traps, and chat history terminator should not be hidden behind aria-hidden because they are focusable, by @compulim, in PR #4659

Description

Focusables (e.g. tabindex="0") should not be hidden behind aria-hidden.

For tests, we will be adding axe-core in #4651 and I verified that it would catch these accessibility issues.

Specific Changes

  • Remove aria-hidden in focus traps
  • Remove aria-hidden for keyboard help screen
    • It is okay to read the help screen even though it is not on-screen
  • Remove aria-hidden for chat history terminator
    • It is okay to read "end of chat history"
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim marked this pull request as ready for review March 2, 2023 19:40
@compulim compulim added the p1 Painful if we don't fix, won't block releasing label Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-accessibility p1 Painful if we don't fix, won't block releasing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility Issue - Inappropriate usage of aria-hidden on focusable elements
2 participants