Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML tests: use <main> for container #4684

Merged
merged 3 commits into from Mar 28, 2023
Merged

HTML tests: use <main> for container #4684

merged 3 commits into from Mar 28, 2023

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Mar 22, 2023 •
edited

Related to #4650.

Changelog Entry

  • Related to #4650. Added automated accessibility check using axe-core
    • HTML test: using <main> for the root container, by @compulim, in PR #4683

Description

In our HTML tests, replace <div id="root"> with <main id="root">. This is one thing flagged by axe-core.

Design

Specific Changes

  • Under __tests__/html/, replace-all <div id="root"></div> with <main id="root"></main>
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim marked this pull request as ready for review March 22, 2023 20:17
@compulim compulim marked this pull request as draft March 22, 2023 23:22
@compulim compulim marked this pull request as ready for review March 22, 2023 23:23
@compulim compulim added this to the imminent milestone Mar 22, 2023
@compulim compulim added the p1 Painful if we don't fix, won't block releasing label Mar 23, 2023
@compulim compulim merged commit 2c853c8 into main Mar 28, 2023
@compulim compulim deleted the feat-html-test-role-main branch March 28, 2023 06:26
@compulim compulim mentioned this pull request Apr 12, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdurnford tdurnford tdurnford approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@beyackle2 beyackle2 Awaiting requested review from beyackle2 beyackle2 is a code owner

Assignees
No one assigned
Labels
area-accessibility p1 Painful if we don't fix, won't block releasing
Projects
None yet
Milestone
imminent
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@compulim @tdurnford