Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no clearImmediate and no store prop #4709

Merged
merged 4 commits into from Apr 14, 2023
Merged

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Apr 14, 2023

Fixes #4708.

Changelog Entry

Fixed

  • Fixes #4708. Should function properly in browsers without setImmediate or without passing store prop, by @compulim, in PR #4709.

Description

When using Web Chat in one of the follow setups, it failed to render:

  • Browsers without clearImmediate and other efficient script yielding proposal
  • Render without passing store prop
  • IE Mode (no globalThis)

Specific Changes

  • Update ponyfill filler in both api and core
  • Add tests to make sure render without store prop will continue to work
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim marked this pull request as ready for review April 14, 2023 01:28
@compulim compulim merged commit 504fb24 into main Apr 14, 2023
8 of 10 checks passed
@compulim compulim deleted the fix-no-clear-immediate branch April 14, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot render Web Chat without store prop
2 participants