Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HIGH] Incorporated PR comments of 4846 #4857

Merged
merged 15 commits into from Sep 15, 2023
Merged

[HIGH] Incorporated PR comments of 4846 #4857

merged 15 commits into from Sep 15, 2023

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Sep 11, 2023 •
edited

Fixes #4856.

Changelog Entry

Added

Description

Incorporated PR comments of #4846.

Also added types for useStyleSet so we don't accidentally used a non-defined style set.

Design

Specific Changes

  • Added CSSTokens for using CSS custom properties
  • Updated return type of useStyleSet to use a better type
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim linked an issue Sep 11, 2023 that may be closed by this pull request
Flush new UIs for better bot response #4856
Closed
@compulim compulim marked this pull request as ready for review September 11, 2023 21:19
@compulim compulim changed the title Incorporated PR comments of 4846 [HIGH] Incorporated PR comments of 4846 Sep 14, 2023
@compulim compulim merged commit bb5898e into main Sep 15, 2023
10 checks passed
@compulim compulim deleted the fix-4856-flush-new-uis branch September 15, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdurnford tdurnford tdurnford approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@beyackle2 beyackle2 Awaiting requested review from beyackle2 beyackle2 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flush new UIs for better bot response
2 participants
@compulim @tdurnford