New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fluent theme] Add Fluent SendBox #5122
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
reviewed
Apr 8, 2024
compulim
reviewed
Apr 8, 2024
compulim
reviewed
Apr 8, 2024
compulim
reviewed
Apr 8, 2024
compulim
reviewed
Apr 8, 2024
compulim
reviewed
Apr 8, 2024
compulim
reviewed
Apr 8, 2024
compulim
reviewed
Apr 8, 2024
compulim
reviewed
Apr 8, 2024
compulim
reviewed
Apr 8, 2024
compulim
reviewed
Apr 8, 2024
compulim
reviewed
Apr 8, 2024
compulim
reviewed
Apr 8, 2024
compulim
reviewed
Apr 8, 2024
compulim
reviewed
Apr 8, 2024
compulim
reviewed
Apr 8, 2024
compulim
reviewed
Apr 8, 2024
compulim
reviewed
Apr 8, 2024
compulim
reviewed
Apr 8, 2024
compulim
reviewed
Apr 8, 2024
compulim
reviewed
Apr 8, 2024
compulim
reviewed
Apr 8, 2024
compulim
reviewed
Apr 8, 2024
compulim
reviewed
Apr 8, 2024
compulim
reviewed
Apr 8, 2024
compulim
reviewed
Apr 8, 2024
compulim
reviewed
Apr 8, 2024
compulim
reviewed
Apr 8, 2024
compulim
reviewed
Apr 8, 2024
compulim
reviewed
Apr 8, 2024
- Added maxMessageLength into styleOptions with default value 2000 - Implemented in SendBox
- focus back tests - auto-resize tests - max-length tests
Added a check to respect message length setting when sending the form via Enter key
While doppelganger isn't scrollable it should use the same scroll styles as the textarea to avoid any discrepancies
Reorganize modules to follow estabilished conventions
The nonce is not a dependency as it is defined in the module scope
compulim
approved these changes
Apr 11, 2024
This is experimental and work-in-progress. We will continue to work on the Fluent theme pack until it is ready for broader consumption. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Breaking changes
useSuggestedActions
type is updated to align with its actual implementation, by @OEvgeny, in PR #5122Added
botframework-webchat-fluent-theme
package for applying Fluent UI theme to Web Chat, by @compulim and @OEvgeny, in PR #5120styleOptions.maxMessageLength
to specify maximum length of the outgoing messageuseMakeThumbnail
hook option to create a thumbnail from the file given, by @compulim, in PR #5123 and #5122Description
Added the
SendBox
,DropZone
,SuggestedActions
andTelephoneKeypad
components intobotframework-fluent-theme
package. The package now includes initial implementation of the new sedbox experience.Design
Specific Changes
TEXT_INPUT_DROP_ZONE
TEXT_INPUT_LENGTH_EXCEEDED_ALT
TEXT_INPUT_ATTACHMENTS_FEW
TEXT_INPUT_ATTACHMENTS_MANY
TEXT_INPUT_ATTACHMENTS_ONE
TEXT_INPUT_ATTACHMENTS_OTHER
TEXT_INPUT_ATTACHMENTS_TWO
useMakeThumbnail
hookDropZone
,SendBox
,SuggestedActions
andTelephoneKeypad
components for the new WebChat Fluent experiencefluent-theme
package bundle containing Fluent related WebChat adjustmentstestIds
for the new components to make testing webchat easierCHANGELOG.md
Review Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index
)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)