Fluent: use grid for sendbox layout #5136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove drop-zone from the grid - Add example layouts into tests - Fix double spacing for attachments
OEvgeny
changed the title
OEvgeny
requested review from
a-b-r-o-w-n,
compulim,
cwhitten,
srinaath,
tdurnford and
beyackle2
as code owners
OEvgeny
changed the title
compulim
reviewed
Apr 17, 2024
compulim
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
botframework-webchat-fluent-themepackage for applying Fluent UI theme to Web Chat, by @compulim and @OEvgenyDescription
The PR enables advanced layout for the experimental Fluent send box experience, also fixing some small issues found along the way.
Design
We now use named areas to manipulate the positioning for
telephone-keypad,text-area,attachmentandcontrols. These areas can then be remapped using CSS to achieve different layouting options.To avoid double gaps we conditionally add the
attachmentarea only when the corresponding to the area class is present.Specific Changes
Sendbutton when telephone keypad is shownCHANGELOG.mdReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)z-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)