Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluent: add sendbox focus animation #5143

Merged
merged 4 commits into from Apr 23, 2024
Merged

Fluent: add sendbox focus animation #5143

merged 4 commits into from Apr 23, 2024

Conversation

OEvgeny
Copy link
Collaborator

@OEvgeny OEvgeny commented Apr 23, 2024

Fixes #

Changelog Entry

Added

  • (Experimental) Added botframework-webchat-fluent-theme package for applying Fluent UI theme to Web Chat, by @compulim and @OEvgeny
    • Added animation to focus indicator and pixel-perfected, in PR #5143

Description

Added animation on SendBox focus / blur actions.
Screencast from 2024-04-23 10-17-25.webm

Design

For our test framework, we force reduced motion, aiming for the following:

  • animations don't break test snapshots
  • we follow reduced motion media for our animations

Specific Changes

  • Add focus/blur sendbox animation
  • Turn on prefer-reduce-motion: reduce media emulation for tests
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@OEvgeny OEvgeny marked this pull request as ready for review April 23, 2024 19:35
compulim
compulim previously approved these changes Apr 23, 2024
@compulim compulim enabled auto-merge (squash) April 23, 2024 20:29
@compulim compulim merged commit d9e4f4d into main Apr 23, 2024
25 checks passed
@compulim compulim deleted the feature/focus-animation branch April 23, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants