Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluent: suggested actions roving focus #5154

Merged
merged 4 commits into from May 1, 2024
Merged

Fluent: suggested actions roving focus #5154

merged 4 commits into from May 1, 2024

Conversation

OEvgeny
Copy link
Collaborator

@OEvgeny OEvgeny commented May 1, 2024

Fixes #

Changelog Entry

  • (Experimental) Added botframework-webchat-fluent-theme package for applying Fluent UI theme to Web Chat, by @compulim and @OEvgeny
    • Added keyboard navigation support into suggested actions, by @OEvgeny in PR #5154

Description

Implemented roving focus using existing implementation as a reference. The new component is now used for suggested actions keyboard support.

Design

The new rovingFocus module implements the roving focus exposing only the RovingFocusProvider and useRovingFocusItemRef.

The module is private for suggestedActions for now. When we find other use-case, we can reconsider and refactor it.

Specific Changes

  • Implemented the roving focus functionality for fluent theme package
  • Added roving focus into suggested actions
  • Added tests

-

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@OEvgeny OEvgeny marked this pull request as ready for review May 1, 2024 20:23
@OEvgeny OEvgeny requested a review from compulim May 1, 2024 20:46
@compulim compulim enabled auto-merge (squash) May 1, 2024 20:48
@compulim compulim merged commit c30e4e2 into main May 1, 2024
25 checks passed
@compulim compulim deleted the feature/roving-focus branch May 1, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants