-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Styles: add shadow DOM support #5196
Open
OEvgeny
wants to merge
42
commits into
main
Choose a base branch
from
feature/shadow-dom
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,199
−152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#5192) * Fluent: increase focused send box text size to prevent unwanted zoom on mobile * Self review * Changelog
* Fluent: allow transcript scroll when sendbox focused * Rework empty check * Fix failing tests * Changelog --------- Co-authored-by: William Wong <compulim@users.noreply.github.com>
* Fix DTMF key command usage * Changelog * Fix star and pound
OEvgeny
commented
May 31, 2024
OEvgeny
commented
May 31, 2024
compulim
reviewed
May 31, 2024
compulim
reviewed
May 31, 2024
compulim
reviewed
May 31, 2024
OEvgeny
commented
Jun 3, 2024
OEvgeny
commented
Jun 3, 2024
OEvgeny
commented
Jun 3, 2024
compulim
reviewed
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
styleOptions.stylesRoot
property allowing users to specify the root node where WebChat styles should be placed, in PR #5196, by @OEvgenyThemeProvider.styles
property, allowing theme packages to place styles into the same root node as WebChat, in PR #5196, by @OEvgenynonce
for Fluent andreact-scroll-to-bottom
injected styles, in PR #5196, by @OEvgenyreact-scroll-to-bottom
to version4.2.1-main.53844f5
, in PR #5196, by @OEvgenyDescription
The change allows to mount webchat inside of shadow roots by providing the container for emotion and Fluent styles.
TODO:
react-scroll-to-bottom
styles: need to update emotion usage on the library side and update the library.react-film
styles: need to update emotion usage on the library side and update the library.Design
The design encapsulates related code into dedicated modules and centralizes style injection.
With the new approach, the Fluent theme passes styles down to WebChat, which then determines the appropriate location to inject these styles.
Instead of calculating the root node before mounting the rest of the component tree, we let user specify the desired location for the styles.
Specific Changes
useStyleToEmotionObject
useInjectStyles
useStyleToEmotionObject
usagestyles
prop toThemeProvider
ContextType
toThemeContextType
injectStyles
tocreateStyles
styleOptions.stylesRoot
-
CHANGELOG.md
I have updated documentationReview Checklist
z-index
)package.json
andpackage-lock.json
reviewed